Resend requests when we only learn a connection has closed while

net/http/http_network_transaction.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <set>
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 1169 matching lines @@
   error = HandleSSLHandshakeError(error);
 
   switch (error) {
     // If we try to reuse a connection that the server is in the process of
     // closing, we may end up successfully writing out our request (or a
     // portion of our request) only to find a connection error when we try to
     // read from (or finish writing to) the socket.
     case ERR_CONNECTION_RESET:
     case ERR_CONNECTION_CLOSED:
     case ERR_CONNECTION_ABORTED:
+    // Under certain circumstances, we may first learn a socket's been

[willchan no longer on Chromium, 2011/12/07 18:46:28]

Can you describe the circumstance? Explain that there's possibly a race between
the socket pool checking for socket connectedness and the actual read/write.

[mmenke, 2011/12/07 19:34:11]

Done.  Added a link to the bug, too, as it now contains some actual details.

+    // disconnected when trying to read/write from it or get its IP address,

[willchan no longer on Chromium, 2011/12/07 18:46:28]

getting the peer's IP address

[mmenke, 2011/12/07 19:34:11]

Completely rewrote the sentence.

+    // before processing the connection closed/reset message.  In this case,
+    // we'll receive the following error code.
+    case ERR_SOCKET_NOT_CONNECTED:
       if (ShouldResendRequest(error)) {
         net_log_.AddEvent(
             NetLog::TYPE_HTTP_TRANSACTION_RESTART_AFTER_ERROR,
             make_scoped_refptr(new NetLogIntegerParameter("net_error", error)));
         ResetConnectionAndRequestForResend();
         error = OK;
       }
       break;
     case ERR_PIPELINE_EVICTION:
     case ERR_SPDY_PING_FAILED:
@@ skipping 140 matching lines @@
       description = base::StringPrintf("Unknown state 0x%08X (%u)", state,
                                        state);
       break;
   }
   return description;
 }
 
 #undef STATE_CASE
 
 }  // namespace net