Add panel overflow logic to panel strip.

Add panel overflow logic to panel strip.

* Renamed strip_bounds_ to display_area_ to avoid confusion
thinking it was a flag to remove info.

Overflow not functional until jianli uncomments the overflow
strip code after he implements an overflow strip.

BUG=None
TEST=Disabled PanelBrowserTest.CreatePanelOnOverflow. jianli will fix.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112572

[jianli, 2011-12-01 21:36:27]

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_manager.h (left):

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_manager.h:47: void OnPanelRemoved(Panel* panel);
Why removing it? PanelOverflowStrip also needs to send the notification for the
panel being removed.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_strip.cc (right):

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.cc:75: if (!panels_.empty() && area.width()
< display_area_.width()) {
Probably better to set new area 1st so that all later rearrangement are based on
this. Like:
  gfx::Rect old_area = display_area_;
  display_area_ = new_area;

  // Nothing to do if no panel.
  if (panels_.empty())
    return;

  if (new_area.width() < old_area.width()) {
    // Might need to move panels to overflow area if the display area is shrunk.
    ...
  } else {
    // Might need to move overflows to normal display if the
display area is enlarged.
    ...
  }

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.cc:76: int min_x = display_area_.right() -
area.width();
display_area_.right() => area.right()
It might be the case that display_area_.right() is not same as area.right() due
to taskbar being aligned to the left screen edge.

In addition, do we want to move overflow panels to the normal strip if the
display area is enlarged?

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.cc:79: DCHECK(!panels_.empty());  // At
least one panel must fit!
This might not be always true if the display area has been shrunk a lot by more
than 2/3 and the 1st panel occupies 1/3 of the original area.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.cc:141: base::Unretained(panel), true),  //
new panel
There could be a case that the new panel is being closed immediately by the
script, though very rarely.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.cc:417: // Reposition all the panels to the
left.
I think this logic could be folded into Rearrange method that will move the
unfit panels to the overflow area automatically.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.cc:426: for  (int i =
static_cast<int>(panels_.size()) - 1; i > panel_index;
extra space after for.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_strip.h (right):

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.h:33: void SetDisplayArea(const gfx::Rect
area);
nit: add "&" after Rect.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.h:137: void MovePanelToOverflow(Panel*
panel, bool is_new);
Could you please add comment for this, like explaining under what kind of
circumstance we need to move the panel to overflow area?

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.h:140: void AddPanelsFromOverflow();
How about MovePanelsFromOverflowIfNeeded?

[jennb, 2011-12-01 23:10:17]

Rearrange now handles overflowing panels.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_manager.h (left):

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_manager.h:47: void OnPanelRemoved(Panel* panel);
On 2011/12/01 21:36:28, jianli wrote:
> Why removing it? PanelOverflowStrip also needs to send the notification for
the
> panel being removed.

Putting back. Obviously a miscommunication from our chat yesterday.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_strip.cc (right):

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.cc:141: base::Unretained(panel), true),  //
new panel
On 2011/12/01 21:36:28, jianli wrote:
> There could be a case that the new panel is being closed immediately by the
> script, though very rarely.

When the delayed method is called, it checks whether the panel is actually in
the strip before doing anything.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_strip.h (right):

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.h:33: void SetDisplayArea(const gfx::Rect
area);
On 2011/12/01 21:36:28, jianli wrote:
> nit: add "&" after Rect.

Done.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.h:137: void MovePanelToOverflow(Panel*
panel, bool is_new);
On 2011/12/01 21:36:28, jianli wrote:
> Could you please add comment for this, like explaining under what kind of
> circumstance we need to move the panel to overflow area?

Done.

http://codereview.chromium.org/8774013/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_strip.h:140: void AddPanelsFromOverflow();
On 2011/12/01 21:36:28, jianli wrote:
> How about MovePanelsFromOverflowIfNeeded?

Done.

[jianli, 2011-12-01 23:19:27]

lgtm