Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 8774013: Add panel overflow logic to panel strip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo, remove dummy code Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/string_number_conversions.h" 6 #include "base/string_number_conversions.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/download/download_service.h" 9 #include "chrome/browser/download/download_service.h"
10 #include "chrome/browser/download/download_service_factory.h" 10 #include "chrome/browser/download/download_service_factory.h"
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, FindBar) { 526 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, FindBar) {
527 Panel* panel = CreatePanelWithBounds("PanelTest", gfx::Rect(0, 0, 400, 400)); 527 Panel* panel = CreatePanelWithBounds("PanelTest", gfx::Rect(0, 0, 400, 400));
528 Browser* browser = panel->browser(); 528 Browser* browser = panel->browser();
529 // FindBar needs tab contents. 529 // FindBar needs tab contents.
530 CreateTestTabContents(browser); 530 CreateTestTabContents(browser);
531 browser->ShowFindBar(); 531 browser->ShowFindBar();
532 ASSERT_TRUE(browser->GetFindBarController()->find_bar()->IsFindBarVisible()); 532 ASSERT_TRUE(browser->GetFindBarController()->find_bar()->IsFindBarVisible());
533 panel->Close(); 533 panel->Close();
534 } 534 }
535 535
536 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, CreatePanelOnOverflow) { 536 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DISABLED_CreatePanelOnOverflow) {
537 TestCreatePanelOnOverflow(); 537 TestCreatePanelOnOverflow();
538 } 538 }
539 539
540 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DragPanels) { 540 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DragPanels) {
541 static const int max_panels = 3; 541 static const int max_panels = 3;
542 static const int zero_delta = 0; 542 static const int zero_delta = 0;
543 static const int small_delta = 10; 543 static const int small_delta = 10;
544 static const int big_delta = 70; 544 static const int big_delta = 70;
545 static const int bigger_delta = 120; 545 static const int bigger_delta = 120;
546 static const int biggest_delta = 200; 546 static const int biggest_delta = 200;
(...skipping 1369 matching lines...) Expand 10 before | Expand all | Expand 10 after
1916 // position when tall panel brings up its titlebar. 1916 // position when tall panel brings up its titlebar.
1917 CloseWindowAndWait(panel1->browser()); 1917 CloseWindowAndWait(panel1->browser());
1918 EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up, 1918 EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up,
1919 GetBalloonBottomPosition(balloon)); 1919 GetBalloonBottomPosition(balloon));
1920 1920
1921 // Closing the remaining tall panel should move the notification balloon back 1921 // Closing the remaining tall panel should move the notification balloon back
1922 // to its original position. 1922 // to its original position.
1923 CloseWindowAndWait(panel2->browser()); 1923 CloseWindowAndWait(panel2->browser());
1924 EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon)); 1924 EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
1925 } 1925 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698