Add panel overflow logic to panel strip.

chrome/browser/ui/panels/panel_strip.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_STRIP_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_STRIP_H_
 #pragma once
 
 #include <vector>
 #include "base/basictypes.h"
@@ skipping 12 matching lines @@
 // All panels in the strip are contained within the bounds of the strip.
 class PanelStrip : public PanelMouseWatcherObserver {
  public:
   typedef std::vector<Panel*> Panels;
 
   explicit PanelStrip(PanelManager* panel_manager);
   virtual ~PanelStrip();
 
   // Sets the bounds of the panel strip.
   // |bounds| is in screen coordinates.
-  void SetBounds(const gfx::Rect bounds);
+  void SetDisplayArea(const gfx::Rect area);

[jianli, 2011/12/01 21:36:28]

nit: add "&" after Rect.

[jennb, 2011/12/01 23:10:17]

Done.

 
   // Adds a panel to the strip. The panel may be a newly created panel or one
   // that is transitioning from another grouping of panels.
   void AddPanel(Panel* panel);
 
   // Returns |false| if the panel is not in the strip.
   bool Remove(Panel* panel);
   void RemoveAll();
 
   // Drags the given panel.
@@ skipping 61 matching lines @@
   void AddNewPanel(Panel* panel);
   void AddExistingPanel(Panel* panel);
 
   // Keep track of the minimized panels to control mouse watching.
   void IncrementMinimizedPanels();
   void DecrementMinimizedPanels();
 
   // Handles all the panels that're delayed to be removed.
   void DelayedRemove();
 
-  // Does the remove. Called from Remove and DelayedRemove.
-  void DoRemove(Panel* panel);
+  // Does the actual remove. Caller is responsible for rearranging
+  // the panel strip if necessary.
+  // Returns |false| if panel is not in the strip.
+  bool DoRemove(Panel* panel);
 
-  // Rearranges the positions of the panels starting from the given iterator.
+  // Rearranges the positions of the panels in the strip.
   // This is called when the display space has been changed, i.e. working
   // area being changed or a panel being closed.
-  void Rearrange(Panels::iterator iter_to_start, int rightmost_position);
+  void Rearrange();
 
   // Help functions to drag the given panel.
   void DragLeft();
   void DragRight();
 
   // Does the real job of bringing up or down the titlebars.
   void DoBringUpOrDownTitlebars(bool bring_up);
   // The callback for a delyed task, checks if it still need to perform
   // the delayed action.
   void DelayedBringUpOrDownTitlebarsCheck();
 
   int GetRightMostAvailablePosition() const;
 
+  void MovePanelToOverflow(Panel* panel, bool is_new);

[jianli, 2011/12/01 21:36:28]

Could you please add comment for this, like explaining under what kind of
circumstance we need to move the panel to overflow area?

[jennb, 2011/12/01 23:10:17]

Done.

+
+  // Adds zero or more panels from overflow as will fit in the panel strip.
+  void AddPanelsFromOverflow();

[jianli, 2011/12/01 21:36:28]

How about MovePanelsFromOverflowIfNeeded?

[jennb, 2011/12/01 23:10:17]

Done.

+
   PanelManager* panel_manager_;  // Weak, owns us.
 
   // All panels in the panel strip must fit within this area.
-  gfx::Rect strip_bounds_;
+  gfx::Rect display_area_;
 
   Panels panels_;
 
   // Stores the panels that are pending to remove. We want to delay the removal
   // when we're in the process of the dragging.
   Panels panels_pending_to_remove_;
 
   int minimized_panel_count_;
   bool are_titlebars_up_;
 
   // Panel to drag.
   size_t dragging_panel_index_;
 
   // Original x coordinate of the panel to drag. This is used to get back to
   // the original position when we cancel the dragging.
   int dragging_panel_original_x_;
 
   // Bounds of the panel to drag. It is first set to the original bounds when
   // the dragging happens. Then it is updated to the position that will be set
   // to when the dragging ends.
   gfx::Rect dragging_panel_bounds_;
 
   // Delayed transitions support. Sometimes transitions between minimized and
   // title-only states are delayed, for better usability with Taskbars/Docks.
   TitlebarAction delayed_titlebar_action_;
   bool remove_delays_for_testing_;
   // Owned by MessageLoop after posting.
   base::WeakPtrFactory<PanelStrip> titlebar_action_factory_;
 
+  // Factory used for moving new panels to overflow after a delay.
+  base::WeakPtrFactory<PanelStrip> overflow_action_factory_;
+
   static const int kPanelsHorizontalSpacing = 4;
 
   // Absolute minimum width and height for panels, including non-client area.
   // Should only be big enough to accomodate a close button on the reasonably
   // recognisable titlebar.
   static const int kPanelMinWidth;
   static const int kPanelMinHeight;
 
   DISALLOW_COPY_AND_ASSIGN(PanelStrip);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_STRIP_H_