Content-initiated navigations from chrome:// pages to chrome:// pages in a new tab must be browse...

Content-initiated navigations from chrome:// pages to chrome:// pages in a new tab must be browser navigations.

BUG=106132
TEST=Chrome os chrome://settings/about page "open source" links work.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113005

[Tom Sepez, 2011-12-02 00:57:25]

Added a selection of OWNERS as reviewers.

[brettw, 2011-12-02 01:03:21]

Do not add a selection of owners as reviewers. Pick the owner you want and make
it clear who should review what. I'm assuming I don't need to look at this
otherwise.

[Tom Sepez, 2011-12-02 01:11:36]

Fine.  John, please take a look and let me know if you can approve this.

[jam, 2011-12-02 02:29:19]

http://codereview.chromium.org/8769026/diff/1/content/renderer/render_view_im...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/8769026/diff/1/content/renderer/render_view_im...
content/renderer/render_view_impl.cc:2073: url.SchemeIs("chrome");
nit: i assume there's a constant somewhere for "chrome"? looking on cs i see
kChromeUIScheme

however we're trying to remove all mention of chrome urls from content. so you
can do this in ChromeContentRendererClient::ShouldFork

[Tom Sepez, 2011-12-02 19:04:24]

Yep.  Much cleaner.  I knew not to include the k-constant from chrome into the
content layer, but felt guilty about the "chrome" string.  Pls. review.

[Tom Sepez, 2011-12-05 17:28:03]

Brett, can you take a look at this now that John is OOO?  Thanks.

[Tom Sepez, 2011-12-05 18:09:27]

On 2011/12/05 17:28:03, Tom Sepez wrote:
> Brett, can you take a look at this now that John is OOO?  Thanks.

Argh, sorry, nevermind, john still here one more day.

[jam, 2011-12-05 18:10:16]

lgtm