Content-initiated navigations from chrome:// pages to chrome:// pages in a new tab must be browse...

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 555 matching lines @@
 bool ChromeContentRendererClient::ShouldFork(WebFrame* frame,
                                              const GURL& url,
                                              bool is_content_initiated,
                                              bool is_initial_navigation,
                                              bool* send_referrer) {
   // If the navigation would cross an app extent boundary, we also need
   // to defer to the browser to ensure process isolation.
   // TODO(erikkay) This is happening inside of a check to is_content_initiated
   // which means that things like the back button won't trigger it.  Is that
   // OK?
-  if (!CrossesExtensionExtents(frame, url, is_initial_navigation))
-    return false;
+  if (CrossesExtensionExtents(frame, url, is_initial_navigation)) {
+    // Include the referrer in this case since we're going from a hosted web
+    // page. (the packaged case is handled previously by the extension
+    // navigation test)
+    *send_referrer = true;
 
-  // Include the referrer in this case since we're going from a hosted web
-  // page. (the packaged case is handled previously by the extension
-  // navigation test)
-  *send_referrer = true;
-
-  if (is_content_initiated) {
-    const Extension* extension =
-        extension_dispatcher_->extensions()->GetByURL(ExtensionURLInfo(url));
-    if (extension && extension->is_app()) {
-      UMA_HISTOGRAM_ENUMERATION(
-          extension_misc::kAppLaunchHistogram,
-          extension_misc::APP_LAUNCH_CONTENT_NAVIGATION,
-          extension_misc::APP_LAUNCH_BUCKET_BOUNDARY);
+    if (is_content_initiated) {
+      const Extension* extension =
+          extension_dispatcher_->extensions()->GetByURL(ExtensionURLInfo(url));
+      if (extension && extension->is_app()) {
+        UMA_HISTOGRAM_ENUMERATION(
+            extension_misc::kAppLaunchHistogram,
+            extension_misc::APP_LAUNCH_CONTENT_NAVIGATION,
+            extension_misc::APP_LAUNCH_BUCKET_BOUNDARY);
+      }
     }
+    return true;
   }
 
-  return true;
+  // Navigating to a new chrome:// scheme (in a new tab) from within a
+  // chrome:// page must be a browser navigation so that the browser can
+  // register the new associated data source.
+  if (is_content_initiated && url.SchemeIs(kChromeUIScheme))
+    return true;
+
+  return false;
 }
 
 bool ChromeContentRendererClient::WillSendRequest(WebKit::WebFrame* frame,
                                                   const GURL& url,
                                                   GURL* new_url) {
   // If the request is for an extension resource, check whether it should be
   // allowed. If not allowed, we reset the URL to something invalid to prevent
   // the request and cause an error.
   if (url.SchemeIs(chrome::kExtensionScheme) &&
       !ExtensionResourceRequestPolicy::CanRequestResource(
@@ skipping 177 matching lines @@
 bool ChromeContentRendererClient::IsOtherExtensionWithWebRequestInstalled() {
   return extension_dispatcher_->IsOtherExtensionWithWebRequestInstalled();
 }
 
 void ChromeContentRendererClient::RegisterPPAPIInterfaceFactories(
     webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) {
   factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory);
 }
 
 }  // namespace chrome