Content-initiated navigations from chrome:// pages to chrome:// pages in a new tab must be browse...

content/renderer/render_view_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 2025 matching lines @@
     OpenURL(frame, url, referrer, default_policy);
     return WebKit::WebNavigationPolicyIgnore;  // Suppress the load here.
   }
 
   // Detect when we're crossing a permission-based boundary (e.g. into or out of
   // an extension or app origin, leaving a WebUI page, etc). We only care about
   // top-level navigations within the current tab (as opposed to, for example,
   // opening a new window). But we sometimes navigate to about:blank to clear a
   // tab, and we want to still allow that.
   //
+  // Note: navigating to a new chrome:// scheme from within a chrome:// page
+  // must be a browser navigation so that the browser can first register the
+  // new associated data source.
+  //
   // Note: we do this only for GET requests because our mechanism for switching
   // processes only issues GET requests. In particular, POST requests don't
   // work, because this mechanism does not preserve form POST data. If it
   // becomes necessary to support process switching for POST requests, we will
   // need to send the request's httpBody data up to the browser process, and
   // issue a special POST navigation in WebKit (via
   // FrameLoader::loadFrameRequest). See ResourceDispatcher and WebURLLoaderImpl
   // for examples of how to send the httpBody data.
   // Note2: We normally don't do this for browser-initiated navigations, since
   // it's pointless to tell the browser about navigations it gave us. But
   // we do potentially ask the browser to handle a redirect that was originally
   // initiated by the browser. See http://crbug.com/70943
   //
   // TODO(creis): Move this redirect check to the browser process to avoid
   // ping-ponging.  See http://crbug.com/72380.
   if (!frame->parent() && (is_content_initiated || is_redirect) &&
       default_policy == WebKit::WebNavigationPolicyCurrentTab &&
       request.httpMethod() == "GET" && !url.SchemeIs(chrome::kAboutScheme)) {
     bool send_referrer = false;
     bool should_fork =
         (enabled_bindings_ & content::BINDINGS_POLICY_WEB_UI) ||
         frame->isViewSourceModeEnabled() ||
-        url.SchemeIs(chrome::kViewSourceScheme);
+        url.SchemeIs(chrome::kViewSourceScheme) ||
+        url.SchemeIs("chrome");

[jam, 2011/12/02 02:29:19]

nit: i assume there's a constant somewhere for "chrome"? looking on cs i see
kChromeUIScheme

however we're trying to remove all mention of chrome urls from content. so you
can do this in ChromeContentRendererClient::ShouldFork

 
     if (!should_fork) {
       // Give the embedder a chance.
       bool is_initial_navigation = page_id_ == -1;
       should_fork = content::GetContentClient()->renderer()->ShouldFork(
           frame, url, is_content_initiated, is_initial_navigation,
           &send_referrer);
     }
 
     if (should_fork) {
@@ skipping 2673 matching lines @@
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit(
     const IPC::ChannelHandle& channel_handle) {
   DCHECK(!java_bridge_dispatcher_.get());
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this, channel_handle));
 #endif
 }