Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8762016: Revert 112305 - Pull the phone library directly. Delete old version. (Closed)

Created:
9 years ago by Ilya Sherman
Modified:
9 years ago
Reviewers:
GeorgeY
CC:
chromium-reviews, GeorgeY, dhollowa+watch_chromium.org, Ilya Sherman, dyu1
Visibility:
Public.

Description

Revert 112305 - Pull the phone library directly. Delete old version. TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8736001 TBR=georgey@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112381

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : Full revert, I hope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58440 lines, -90 lines) Patch
M DEPS View 1 2 3 4 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/autofill/phone_number_i18n.cc View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/libphonenumber/README.chromium View 1 2 3 4 2 chunks +12 lines, -10 lines 0 comments Download
A third_party/libphonenumber/cpp/CMakeLists.txt View 1 2 3 4 1 chunk +329 lines, -0 lines 0 comments Download
A + third_party/libphonenumber/cpp/LICENSE View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/libphonenumber/cpp/README View 1 2 3 4 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/default_logger.h View 1 2 3 4 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/default_logger.cc View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/encoding_utils.h View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/lite_metadata.cc View 1 2 3 4 1 chunk +9055 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/logger.h View 1 2 3 4 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/logger.cc View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/logger_test.cc View 1 2 3 4 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/metadata.h View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/metadata.cc View 1 2 3 4 1 chunk +9830 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/normalize_utf8.h View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumber.h View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumber.cc View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumberutil.h View 1 2 3 4 1 chunk +647 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumberutil.cc View 1 2 3 4 1 chunk +2177 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumberutil_test.cc View 1 2 3 4 1 chunk +2925 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_adapter.h View 1 2 3 4 1 chunk +162 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_adapter_icu.cc View 1 2 3 4 1 chunk +209 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_adapter_re2.cc View 1 2 3 4 1 chunk +163 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_adapter_test.cc View 1 2 3 4 1 chunk +198 lines, -0 lines 0 comments Download
third_party/libphonenumber/cpp/src/regexp_cache.h View 1 2 3 4 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_cache.cc View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_cache_test.cc View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/region_code.h View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/run_tests.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/stl_util.h View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/stringutil.h View 1 2 3 4 1 chunk +130 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/stringutil.cc View 1 2 3 4 1 chunk +298 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/stringutil_test.cc View 1 2 3 4 1 chunk +231 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/test_metadata.cc View 1 2 3 4 1 chunk +665 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/README View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/rune.c View 1 2 3 4 1 chunk +350 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/stringpiece.h View 1 2 3 4 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/stringprintf.h View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unicodetext.h View 1 2 3 4 1 chunk +456 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unicodetext.cc View 1 2 3 4 1 chunk +515 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unicodetext_test.cc View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unilib.h View 1 2 3 4 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unilib.cc View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/utf.h View 1 2 3 4 1 chunk +251 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/utfdef.h View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 1 2 3 4 3 chunks +26 lines, -38 lines 0 comments Download
A third_party/libphonenumber/patches/version277a.patch View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/PhoneNumberMetaData.xml View 1 2 3 4 1 chunk +20321 lines, -0 lines 0 comments Download
third_party/libphonenumber/resources/PhoneNumberMetaDataForTesting.xml View 1 2 3 4 1 chunk +730 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/de/43.txt View 1 2 3 4 1 chunk +1037 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/de/49.txt View 1 2 3 4 1 chunk +3528 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/en/1.txt View 1 2 3 4 1 chunk +316 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/en/44.txt View 1 2 3 4 1 chunk +853 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/en/82.txt View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/es/34.txt View 1 2 3 4 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/es/54.txt View 1 2 3 4 1 chunk +225 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/es/56.txt View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/ko/82.txt View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/nl/31.txt View 1 2 3 4 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/pt/55.txt View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/sv/46.txt View 1 2 3 4 1 chunk +266 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/zh/82.txt View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/zh/86.txt View 1 2 3 4 1 chunk +339 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/geocoding/zh_Hant/82.txt View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/phonemetadata.proto View 1 2 3 4 1 chunk +235 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/phonenumber.proto View 1 2 3 4 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/test/geocoding/en/1.txt View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/test/geocoding/en/82.txt View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/test/geocoding/ko/82.txt View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
D third_party/libphonenumber/src/LICENSE View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libphonenumber/src/phonenumber_api.h View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ilya Sherman
9 years ago (2011-12-01 02:17:26 UTC) #1
Ilya Sherman
9 years ago (2011-12-01 02:17:49 UTC) #2 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698