Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8736001: Pull the phone library directly. Delete old version. (Closed)

Created:
9 years ago by GeorgeY
Modified:
9 years ago
CC:
chromium-reviews, GeorgeY, Ilya Sherman, dyu1, jshin+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Pull the phone library directly. Delete old version. TEST=unit-tests BUG=105577 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112305

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -58454 lines) Patch
M DEPS View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/autofill/phone_number_i18n.cc View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/libphonenumber/README.chromium View 1 2 3 4 2 chunks +9 lines, -12 lines 0 comments Download
D third_party/libphonenumber/cpp/CMakeLists.txt View 1 2 3 4 1 chunk +0 lines, -329 lines 0 comments Download
D third_party/libphonenumber/cpp/LICENSE View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libphonenumber/cpp/README View 1 2 3 4 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/libphonenumber/cpp/src/default_logger.h View 1 2 3 4 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/libphonenumber/cpp/src/default_logger.cc View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/libphonenumber/cpp/src/encoding_utils.h View 1 2 3 4 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/libphonenumber/cpp/src/lite_metadata.cc View 1 2 3 4 1 chunk +0 lines, -9055 lines 0 comments Download
D third_party/libphonenumber/cpp/src/logger.h View 1 2 3 4 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/libphonenumber/cpp/src/logger.cc View 1 2 3 4 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/libphonenumber/cpp/src/logger_test.cc View 1 2 3 4 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/libphonenumber/cpp/src/metadata.h View 1 2 3 4 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/libphonenumber/cpp/src/metadata.cc View 1 2 3 4 1 chunk +0 lines, -9830 lines 0 comments Download
D third_party/libphonenumber/cpp/src/normalize_utf8.h View 1 2 3 4 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumber.h View 1 2 3 4 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumber.cc View 1 2 3 4 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumberutil.h View 1 2 3 4 1 chunk +0 lines, -647 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumberutil.cc View 1 2 3 4 1 chunk +0 lines, -2177 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumberutil_test.cc View 1 2 3 4 1 chunk +0 lines, -2925 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter.h View 1 2 3 4 1 chunk +0 lines, -162 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter_icu.cc View 1 2 3 4 1 chunk +0 lines, -209 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter_re2.cc View 1 2 3 4 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter_test.cc View 1 2 3 4 1 chunk +0 lines, -198 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_cache.h View 1 2 3 4 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_cache.cc View 1 2 3 4 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_cache_test.cc View 1 2 3 4 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/libphonenumber/cpp/src/region_code.h View 1 2 3 4 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/libphonenumber/cpp/src/run_tests.cc View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stl_util.h View 1 2 3 4 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stringutil.h View 1 2 3 4 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stringutil.cc View 1 2 3 4 1 chunk +0 lines, -298 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stringutil_test.cc View 1 2 3 4 1 chunk +0 lines, -231 lines 0 comments Download
D third_party/libphonenumber/cpp/src/test_metadata.cc View 1 2 3 4 1 chunk +0 lines, -665 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/README View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D third_party/libphonenumber/cpp/src/utf/rune.c View 1 2 3 4 1 chunk +0 lines, -350 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/stringpiece.h View 1 2 3 4 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/stringprintf.h View 1 2 3 4 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unicodetext.h View 1 2 3 4 1 chunk +0 lines, -456 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unicodetext.cc View 1 2 3 4 1 chunk +0 lines, -515 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unicodetext_test.cc View 1 2 3 4 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unilib.h View 1 2 3 4 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unilib.cc View 1 2 3 4 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/utf.h View 1 2 3 4 1 chunk +0 lines, -251 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/utfdef.h View 1 2 3 4 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 1 2 3 4 3 chunks +38 lines, -26 lines 0 comments Download
D third_party/libphonenumber/patches/version277a.patch View 1 2 3 4 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/libphonenumber/resources/PhoneNumberMetaData.xml View 1 2 3 4 1 chunk +0 lines, -20321 lines 0 comments Download
D third_party/libphonenumber/resources/PhoneNumberMetaDataForTesting.xml View 1 2 3 4 1 chunk +0 lines, -730 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/de/43.txt View 1 2 3 4 1 chunk +0 lines, -1037 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/de/49.txt View 1 2 3 4 1 chunk +0 lines, -3528 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/en/1.txt View 1 2 3 4 1 chunk +0 lines, -316 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/en/44.txt View 1 2 3 4 1 chunk +0 lines, -853 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/en/82.txt View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/es/34.txt View 1 2 3 4 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/es/54.txt View 1 2 3 4 1 chunk +0 lines, -225 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/es/56.txt View 1 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/ko/82.txt View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/nl/31.txt View 1 2 3 4 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/pt/55.txt View 1 2 3 4 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/sv/46.txt View 1 2 3 4 1 chunk +0 lines, -266 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/zh/82.txt View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/zh/86.txt View 1 2 3 4 1 chunk +0 lines, -339 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/zh_Hant/82.txt View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/phonemetadata.proto View 1 2 3 4 1 chunk +0 lines, -235 lines 0 comments Download
D third_party/libphonenumber/resources/phonenumber.proto View 1 2 3 4 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/libphonenumber/resources/test/geocoding/en/1.txt View 1 2 3 4 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/libphonenumber/resources/test/geocoding/en/82.txt View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/test/geocoding/ko/82.txt View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
A third_party/libphonenumber/src/LICENSE View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/libphonenumber/src/phonenumber_api.h View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
GeorgeY
Nicolas for the DEPS change
9 years ago (2011-11-29 22:20:37 UTC) #1
Ilya Sherman
http://codereview.chromium.org/8736001/diff/11049/chrome/browser/autofill/phone_number_i18n.cc File chrome/browser/autofill/phone_number_i18n.cc (right): http://codereview.chromium.org/8736001/diff/11049/chrome/browser/autofill/phone_number_i18n.cc#newcode14 chrome/browser/autofill/phone_number_i18n.cc:14: #include "third_party/libphonenumber/src/phonenumbers/phonenumberutil.h" Hmm, I don't like that every Chromium ...
9 years ago (2011-11-29 22:36:31 UTC) #2
nsylvain
On 2011/11/29 22:20:37, GeorgeY wrote: > Nicolas for the DEPS change I'm currently creating the ...
9 years ago (2011-11-29 23:03:31 UTC) #3
nsylvain
DEPS file LGTM. Mirrors have been created. Make sure to send a try job and ...
9 years ago (2011-11-29 23:43:43 UTC) #4
GeorgeY
http://codereview.chromium.org/8736001/diff/11024/third_party/libphonenumber/README.chromium File third_party/libphonenumber/README.chromium (right): http://codereview.chromium.org/8736001/diff/11024/third_party/libphonenumber/README.chromium#newcode1 third_party/libphonenumber/README.chromium:1: Name: International Phone Number Library On 2011/11/29 23:43:43, nsylvain ...
9 years ago (2011-11-29 23:58:45 UTC) #5
Ilya Sherman
9 years ago (2011-11-30 00:10:24 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld 408576698