Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 8759017: BookmarkModel cleanup. synced_node is now mobile_node and I'm nuking (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, Erik does not do reviews, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, brettw-cc_chromium.org, estade+watch_chromium.org, tim (not reviewing), Ilya Sherman
Visibility:
Public.

Description

BookmarkModel cleanup. synced_node is now mobile_node and I'm nuking IsVisible as it's no longer needed. This cl resulted in a ton of changes, the majority are renames though. BUG=102714 TEST=covered by tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112558

Patch Set 1 #

Patch Set 2 : Remove more IsVisible #

Patch Set 3 : Merge to trunk #

Patch Set 4 : Merge to trunk fix sync_integration_tests and extension test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -400 lines) Patch
M chrome/app/generated_resources.grd View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 8 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_helpers.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.h View 6 chunks +8 lines, -36 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 2 9 chunks +8 lines, -36 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 2 10 chunks +20 lines, -49 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/history/history_types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/starred_url_database.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/engine/download_updates_command.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 9 chunks +23 lines, -34 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 14 chunks +28 lines, -30 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk_unittest.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_tree_model.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/webui/ntp/bookmarks_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/bookmark_manager/edit_disabled/test.js View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/testserver/chromiumsync.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/models/tree_node_iterator.h View 3 chunks +4 lines, -34 lines 0 comments Download
M ui/base/models/tree_node_iterator_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
brett: bookmarks renaming and history changes tim: sync changes mrosetti: cocoa changes erg: gtk ben: ...
9 years ago (2011-12-01 18:44:42 UTC) #1
Elliot Glaysher
lgtm stamping the gtk portions since they're so basic.
9 years ago (2011-12-01 18:54:45 UTC) #2
brettw
lgtm
9 years ago (2011-12-01 19:17:41 UTC) #3
asargent_no_longer_on_chrome
extensions change LGTM
9 years ago (2011-12-01 19:20:44 UTC) #4
mrossetti
Cocoa changes: LGTM
9 years ago (2011-12-01 19:50:27 UTC) #5
akalin
sync lgtm
9 years ago (2011-12-01 21:31:53 UTC) #6
Ben Goodger (Google)
lgtm
9 years ago (2011-12-01 21:37:43 UTC) #7
Evan Stade
if you sync, the webui file in this change list will go away
9 years ago (2011-12-01 22:20:51 UTC) #8
sky
9 years ago (2011-12-01 22:37:05 UTC) #9
Indeed.
Thanks!

  -Scott

On Thu, Dec 1, 2011 at 2:20 PM,  <estade@chromium.org> wrote:
> if you sync, the webui file in this change list will go away
>
> http://codereview.chromium.org/8759017/

Powered by Google App Engine
This is Rietveld 408576698