Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/bookmarks/recently_used_folders_combo_model.cc

Issue 8759017: BookmarkModel cleanup. synced_node is now mobile_node and I'm nuking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to trunk fix sync_integration_tests and extension test Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/recently_used_folders_combo_model.h" 5 #include "chrome/browser/bookmarks/recently_used_folders_combo_model.h"
6 6
7 #include "chrome/browser/bookmarks/bookmark_utils.h" 7 #include "chrome/browser/bookmarks/bookmark_utils.h"
8 #include "grit/generated_resources.h" 8 #include "grit/generated_resources.h"
9 #include "ui/base/l10n/l10n_util.h" 9 #include "ui/base/l10n/l10n_util.h"
10 10
11 namespace { 11 namespace {
12 12
13 // Max number of most recently used folders. 13 // Max number of most recently used folders.
14 const size_t kMaxMRUFolders = 5; 14 const size_t kMaxMRUFolders = 5;
15 15
16 } // namespace 16 } // namespace
17 17
18 RecentlyUsedFoldersComboModel::RecentlyUsedFoldersComboModel( 18 RecentlyUsedFoldersComboModel::RecentlyUsedFoldersComboModel(
19 BookmarkModel* model, 19 BookmarkModel* model,
20 const BookmarkNode* node) 20 const BookmarkNode* node)
21 // Use + 2 to account for bookmark bar and other node. 21 // Use + 2 to account for bookmark bar and other node.
22 : nodes_(bookmark_utils::GetMostRecentlyModifiedFolders( 22 : nodes_(bookmark_utils::GetMostRecentlyModifiedFolders(
23 model, kMaxMRUFolders + 2)), 23 model, kMaxMRUFolders + 2)),
24 node_parent_index_(0) { 24 node_parent_index_(0) {
25 // TODO(sky): bug 1173415 add a separator in the combobox here. 25 // TODO(sky): bug 1173415 add a separator in the combobox here.
26 26
27 // We special case the placement of these, so remove them from the list, then 27 // We special case the placement of these, so remove them from the list, then
28 // fix up the order. 28 // fix up the order.
29 RemoveNode(model->bookmark_bar_node()); 29 RemoveNode(model->bookmark_bar_node());
30 RemoveNode(model->synced_node()); 30 RemoveNode(model->mobile_node());
31 RemoveNode(model->other_node()); 31 RemoveNode(model->other_node());
32 RemoveNode(node->parent()); 32 RemoveNode(node->parent());
33 33
34 // Make the parent the first item, unless it's a permanent node, which is 34 // Make the parent the first item, unless it's a permanent node, which is
35 // added below. 35 // added below.
36 if (!model->is_permanent_node(node->parent())) 36 if (!model->is_permanent_node(node->parent()))
37 nodes_.insert(nodes_.begin(), node->parent()); 37 nodes_.insert(nodes_.begin(), node->parent());
38 38
39 // Make sure we only have kMaxMRUFolders in the first chunk. 39 // Make sure we only have kMaxMRUFolders in the first chunk.
40 if (nodes_.size() > kMaxMRUFolders) 40 if (nodes_.size() > kMaxMRUFolders)
41 nodes_.erase(nodes_.begin() + kMaxMRUFolders, nodes_.end()); 41 nodes_.erase(nodes_.begin() + kMaxMRUFolders, nodes_.end());
42 42
43 // And put the bookmark bar and other nodes at the end of the list. 43 // And put the bookmark bar and other nodes at the end of the list.
44 nodes_.push_back(model->bookmark_bar_node()); 44 nodes_.push_back(model->bookmark_bar_node());
45 nodes_.push_back(model->other_node()); 45 nodes_.push_back(model->other_node());
46 if (model->synced_node()->IsVisible()) 46 nodes_.push_back(model->mobile_node());
47 nodes_.push_back(model->synced_node());
48 47
49 std::vector<const BookmarkNode*>::iterator it = std::find(nodes_.begin(), 48 std::vector<const BookmarkNode*>::iterator it = std::find(nodes_.begin(),
50 nodes_.end(), 49 nodes_.end(),
51 node->parent()); 50 node->parent());
52 node_parent_index_ = static_cast<int>(it - nodes_.begin()); 51 node_parent_index_ = static_cast<int>(it - nodes_.begin());
53 } 52 }
54 53
55 RecentlyUsedFoldersComboModel::~RecentlyUsedFoldersComboModel() {} 54 RecentlyUsedFoldersComboModel::~RecentlyUsedFoldersComboModel() {}
56 55
57 int RecentlyUsedFoldersComboModel::GetItemCount() { 56 int RecentlyUsedFoldersComboModel::GetItemCount() {
(...skipping 13 matching lines...) Expand all
71 return nodes_[index]; 70 return nodes_[index];
72 } 71 }
73 72
74 void RecentlyUsedFoldersComboModel::RemoveNode(const BookmarkNode* node) { 73 void RecentlyUsedFoldersComboModel::RemoveNode(const BookmarkNode* node) {
75 std::vector<const BookmarkNode*>::iterator it = std::find(nodes_.begin(), 74 std::vector<const BookmarkNode*>::iterator it = std::find(nodes_.begin(),
76 nodes_.end(), 75 nodes_.end(),
77 node); 76 node);
78 if (it != nodes_.end()) 77 if (it != nodes_.end())
79 nodes_.erase(it); 78 nodes_.erase(it);
80 } 79 }
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698