Launch Me2Me connections in a new tab. Remove OK button from post-connect screens for Me2Me.

Launch Me2Me connections in a new tab. Remove OK button from post-connect screens for Me2Me.

BUG=105954
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112511

[Jamie, 2011-11-30 21:23:43]

ptal

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/_locales...
File remoting/webapp/me2mom/_locales/en/messages.json (right):

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/_locales...
remoting/webapp/me2mom/_locales/en/messages.json:152: "description": "Message
displayed on the client while a connection to the host is being established."
Since this message is displayed for both IT2Me and Me2Me, it needs to be more
generic. We could use different messages, but this seems fine.

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/choice.html
File remoting/webapp/me2mom/choice.html (right):

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:249: <div
data-ui-mode="client.connect-failed.it2me client.session-finished.it2me"
Don't show this button for Me2Me. For technical reasons, we can't make this
button close the tab, and there's nothing else it could sensibly do, so let's
just omit it for now.

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_screen.js (left):

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_screen.js:427:
remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
I'm not sure why this was being done so late in the connection process, but the
use of asynchronous connect highlights that it should be done earlier.

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_screen.js (right):

http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_screen.js:441:
remoting.wcsLoader.startAsync(callWithToken, remoting.connectHostWithWcs);
The token might not be valid any more, especially if launching from a bookmark,
so we have to do this asynchronously.

[garykac, 2011-12-01 01:25:19]

On 2011/11/30 21:23:43, Jamie wrote:
> ptal
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/_locales...
> File remoting/webapp/me2mom/_locales/en/messages.json (right):
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/_locales...
> remoting/webapp/me2mom/_locales/en/messages.json:152: "description": "Message
> displayed on the client while a connection to the host is being established."
> Since this message is displayed for both IT2Me and Me2Me, it needs to be more
> generic. We could use different messages, but this seems fine.
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/choice.html
> File remoting/webapp/me2mom/choice.html (right):
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/choice.h...
> remoting/webapp/me2mom/choice.html:249: <div
> data-ui-mode="client.connect-failed.it2me client.session-finished.it2me"
> Don't show this button for Me2Me. For technical reasons, we can't make this
> button close the tab, and there's nothing else it could sensibly do, so let's
> just omit it for now.
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
> File remoting/webapp/me2mom/client_screen.js (left):
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
> remoting/webapp/me2mom/client_screen.js:427:
> remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
> I'm not sure why this was being done so late in the connection process, but
the
> use of asynchronous connect highlights that it should be done earlier.
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
> File remoting/webapp/me2mom/client_screen.js (right):
> 
>
http://codereview.chromium.org/8758001/diff/1/remoting/webapp/me2mom/client_s...
> remoting/webapp/me2mom/client_screen.js:441:
> remoting.wcsLoader.startAsync(callWithToken, remoting.connectHostWithWcs);
> The token might not be valid any more, especially if launching from a
bookmark,
> so we have to do this asynchronously.

LGTM

[commit-bot: I haz the power, 2011-12-01 18:57:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/8758001/1

[commit-bot: I haz the power, 2011-12-01 20:12:04]

Change committed as 112511