Replace \n in message strings to acutal new lines.

Replace \n in message strings to acutal new lines.

I had added a hack in http://codereview.chromium.org/196007 to mimic a
behavior of how rc.exe replaces \n with a newline.  Unfortunately, this
didn't make it possible to have legitimate uses of \n in a string.

Instead, remove all occurrences of \n in preparation of removing this hack.

BUG=105985
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112526

[mmenke, 2011-12-01 00:20:52]

http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:3847: """
GRIT will eat these, while maintaining whitespace before them?

[tony, 2011-12-01 00:26:52]

On 2011/12/01 00:20:52, Matt Menke wrote:
>
http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources.grd
> File chrome/app/generated_resources.grd (right):
> 
>
http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources....
> chrome/app/generated_resources.grd:3847: """
> GRIT will eat these, while maintaining whitespace before them?

I thought so, but when double checking, it's ''' only.  Here's the relevant
code:
http://code.google.com/p/grit-i18n/source/browse/trunk/grit/node/message.py#237

Updated to use ''' instead.

[mmenke, 2011-12-01 01:34:20]

On 2011/12/01 00:26:52, tony wrote:
> On 2011/12/01 00:20:52, Matt Menke wrote:
> >
>
http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources.grd
> > File chrome/app/generated_resources.grd (right):
> > 
> >
>
http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources....
> > chrome/app/generated_resources.grd:3847: """
> > GRIT will eat these, while maintaining whitespace before them?
> 
> I thought so, but when double checking, it's ''' only.  Here's the relevant
> code:
>
http://code.google.com/p/grit-i18n/source/browse/trunk/grit/node/message.py#237
> 
> Updated to use ''' instead.

I don't really know Python.  Code actually looks incorrect to me.  Looks like it
always appends "'''" to the last item, and then just removes it again in
node.py, but messing around with grit files, the behavior is as you describe, so
I'll take your word for it.

The behavior the Python code currently exhibits (As opposed to what it looks to
me like it should be exhibiting, given the code), string changes LGTM, though I
strongly suggest you wait for Joi's sign off as well.

[mmenke, 2011-12-01 01:37:05]

On 2011/12/01 01:34:20, Matt Menke wrote:
> On 2011/12/01 00:26:52, tony wrote:
> > On 2011/12/01 00:20:52, Matt Menke wrote:
> > >
> >
>
http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources.grd
> > > File chrome/app/generated_resources.grd (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/8757009/diff/1/chrome/app/generated_resources....
> > > chrome/app/generated_resources.grd:3847: """
> > > GRIT will eat these, while maintaining whitespace before them?
> > 
> > I thought so, but when double checking, it's ''' only.  Here's the relevant
> > code:
> >
>
http://code.google.com/p/grit-i18n/source/browse/trunk/grit/node/message.py#237
> > 
> > Updated to use ''' instead.
> 
> I don't really know Python.  Code actually looks incorrect to me.  Looks like
it
> always appends "'''" to the last item, and then just removes it again in
> node.py, but messing around with grit files, the behavior is as you describe,
so
> I'll take your word for it.
> 
> The behavior the Python code currently exhibits (As opposed to what it looks
to
> me like it should be exhibiting, given the code), string changes LGTM, though
I
> strongly suggest you wait for Joi's sign off as well.

Sorry, that should be "Given the behavior the Python code currently exhibits ...
LGTM ..."

[Jói, 2011-12-01 10:22:10]

LGTM once you fix the issue below.

Before committing I would suggest running grit to build the files and looking at
a couple of the generated .rc files (or other format e.g. data pack) to make
sure the line breaks come through alright.

Thanks for doing this!

Cheers,
Jói

http://codereview.chromium.org/8757009/diff/6/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8757009/diff/6/chrome/app/generated_resources....
chrome/app/generated_resources.grd:9488: <ph name="APPLICATION">$1<ex>C:\Program
Files\Adobe\Reader 8.0\Reader\AcroRd32.exe /u "%1"</ex></ph>
I think you missed a line break here (should be double).  Also, not sure whether
the space before <ph name="APPLICATION"> in the original version was
intentional.

[tony, 2011-12-01 19:26:42]

On 2011/12/01 10:22:10, Jói wrote:
> LGTM once you fix the issue below.
> 
> Before committing I would suggest running grit to build the files and looking
at
> a couple of the generated .rc files (or other format e.g. data pack) to make
> sure the line breaks come through alright.

I tested this on both Windows and Linux and the line breaks are in the pak
files.

>
http://codereview.chromium.org/8757009/diff/6/chrome/app/generated_resources.grd
> File chrome/app/generated_resources.grd (right):
> 
>
http://codereview.chromium.org/8757009/diff/6/chrome/app/generated_resources....
> chrome/app/generated_resources.grd:9488: <ph
name="APPLICATION">$1<ex>C:\Program
> Files\Adobe\Reader 8.0\Reader\AcroRd32.exe /u "%1"</ex></ph>
> I think you missed a line break here (should be double).  Also, not sure
whether
> the space before <ph name="APPLICATION"> in the original version was
> intentional.

Good catch.  I added another line break.  I'm not sure if the space is
intentional or not, so I left it in.

Thanks!

[commit-bot: I haz the power, 2011-12-01 19:27:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8757009/9001

[commit-bot: I haz the power, 2011-12-01 20:48:43]

Change committed as 112526