Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 196007: Implement the history is too old dialog on Linux and update (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update grit to replace \n to actual new lines in data pack files. Windows' MessageBox automatically converts \n to a new line, but GTK+ doesn't. BUG=20943

Patch Set 1 #

Patch Set 2 : grit only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/grit/grit/node/message.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
I can revert the history.cc change if you want me to do it the right ...
11 years, 3 months ago (2009-09-03 21:10:05 UTC) #1
Evan Stade
It looks like you are right about the right way to do it. You don't ...
11 years, 3 months ago (2009-09-03 22:53:11 UTC) #2
tony
On 2009/09/03 22:53:11, Evan Stade wrote: > It looks like you are right about the ...
11 years, 3 months ago (2009-09-03 23:47:59 UTC) #3
Evan Stade
On 2009/09/03 23:47:59, tony wrote: > On 2009/09/03 22:53:11, Evan Stade wrote: > > It ...
11 years, 3 months ago (2009-09-04 00:04:46 UTC) #4
Evan Stade
11 years, 3 months ago (2009-09-04 00:04:59 UTC) #5
that is to say, LGTM

Powered by Google App Engine
This is Rietveld 408576698