Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/chromeos/options/wifi_config_view.cc

Issue 8748001: Make text input type and password visibility bit independent in Textfield (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Textfield(STYLE_OBSCURED) sets TEXT_INPUT_TYPE_PASSWORD Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/options/wifi_config_view.cc
diff --git a/chrome/browser/chromeos/options/wifi_config_view.cc b/chrome/browser/chromeos/options/wifi_config_view.cc
index 2d57618ff96a270d20e7ae0ce0c26586de67bd35..1fc4a41e9d50331561f9be617d40bfb64927ff6a 100644
--- a/chrome/browser/chromeos/options/wifi_config_view.cc
+++ b/chrome/browser/chromeos/options/wifi_config_view.cc
@@ -508,9 +508,9 @@ void WifiConfigView::ButtonPressed(views::Button* sender,
const views::Event& event) {
if (sender == passphrase_visible_button_) {
if (passphrase_textfield_) {
- passphrase_textfield_->SetPassword(!passphrase_textfield_->IsPassword());
- passphrase_visible_button_->SetToggled(
- !passphrase_textfield_->IsPassword());
+ bool obscure = !passphrase_textfield_->IsObscured();
+ passphrase_textfield_->SetObscured(obscure);
+ passphrase_visible_button_->SetToggled(!obscure);
}
} else {
NOTREACHED();
@@ -909,7 +909,7 @@ void WifiConfigView::Init(WifiNetwork* wifi, bool show_8021x) {
l10n_util::GetStringUTF16(label_text_id));
layout->AddView(passphrase_label_);
passphrase_textfield_ = new views::Textfield(
- views::Textfield::STYLE_PASSWORD);
+ views::Textfield::STYLE_OBSCURED);
passphrase_textfield_->SetController(this);
if (wifi && !wifi->GetPassphrase().empty())
passphrase_textfield_->SetText(UTF8ToUTF16(wifi->GetPassphrase()));

Powered by Google App Engine
This is Rietveld 408576698