ui/views/controls/textfield/native_textfield_gtk.h - Issue 8748001: Make text input type and password visibility bit independent in Textfield

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/native_textfield_gtk.h

Issue 8748001: Make text input type and password visibility bit independent in Textfield (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Textfield(STYLE_OBSCURED) sets TEXT_INPUT_TYPE_PASSWORD Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/native_textfield_gtk.h

diff --git a/ui/views/controls/textfield/native_textfield_gtk.h b/ui/views/controls/textfield/native_textfield_gtk.h

index 42a9680304d370ad969c286206fc5c7e080a8f97..b4241f2fa1f2cabd6561274a9b2985c92922db56 100644

--- a/ui/views/controls/textfield/native_textfield_gtk.h

+++ b/ui/views/controls/textfield/native_textfield_gtk.h

@@ -44,7 +44,7 @@ class NativeTextfieldGtk : public NativeControlGtk,

virtual void UpdateBackgroundColor() OVERRIDE;

virtual void UpdateReadOnly() OVERRIDE;

virtual void UpdateFont() OVERRIDE;

- virtual void UpdateIsPassword() OVERRIDE;

+ virtual void UpdateIsObscured() OVERRIDE;

virtual void UpdateEnabled() OVERRIDE;

virtual gfx::Insets CalculateInsets() OVERRIDE;

virtual void UpdateHorizontalMargins() OVERRIDE;

@@ -72,7 +72,7 @@ class NativeTextfieldGtk : public NativeControlGtk,

virtual void NativeControlCreated(GtkWidget* widget) OVERRIDE;

// Returns true if the textfield is for password.

bryeung 2011/12/07 19:33:15 please update the comment now as well

benrg 2011/12/07 21:33:20 Done. I hope that's all of them.

- bool IsPassword();

+ bool IsObscured();

private:

// Gtk signal callbacks.

« no previous file with comments | « ui/gfx/render_text.cc ('k') | ui/views/controls/textfield/native_textfield_gtk.cc » ('j') | ui/views/controls/textfield/textfield.h » ('J')