chrome/browser/chromeos/options/vpn_config_view.cc - Issue 8748001: Make text input type and password visibility bit independent in Textfield

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/options/vpn_config_view.cc

Issue 8748001: Make text input type and password visibility bit independent in Textfield (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Textfield(STYLE_OBSCURED) sets TEXT_INPUT_TYPE_PASSWORD Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screen_lock_view.cc ('k') | chrome/browser/chromeos/options/wifi_config_view.cc » ('j') | ui/views/controls/textfield/native_textfield_gtk.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/options/vpn_config_view.cc

diff --git a/chrome/browser/chromeos/options/vpn_config_view.cc b/chrome/browser/chromeos/options/vpn_config_view.cc

index 9bf34c3b90fb3242226c5702a36ae57618c3b325..a28dc07d98b3f1a5c3d16cd43c6d7b158c4e45a2 100644

--- a/chrome/browser/chromeos/options/vpn_config_view.cc

+++ b/chrome/browser/chromeos/options/vpn_config_view.cc

@@ -484,7 +484,7 @@ void VPNConfigView::Init(VirtualNetwork* vpn) {

IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_PSK_PASSPHRASE));

layout->AddView(psk_passphrase_label_);

psk_passphrase_textfield_ = new views::Textfield(

- views::Textfield::STYLE_PASSWORD);

+ views::Textfield::STYLE_OBSCURED);

psk_passphrase_textfield_->SetController(this);

if (vpn && !vpn->psk_passphrase().empty())

psk_passphrase_textfield_->SetText(UTF8ToUTF16(vpn->psk_passphrase()));

@@ -552,7 +552,7 @@ void VPNConfigView::Init(VirtualNetwork* vpn) {

layout->AddView(new views::Label(l10n_util::GetStringUTF16(

IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_USER_PASSPHRASE)));

user_passphrase_textfield_ = new views::Textfield(

- views::Textfield::STYLE_PASSWORD);

+ views::Textfield::STYLE_OBSCURED);

user_passphrase_textfield_->SetController(this);

user_passphrase_textfield_->SetEnabled(user_passphrase_ui_data_.editable());

if (vpn && !vpn->user_passphrase().empty())