Issue 8742022: Relands the following. First attempt was reverted because it broke

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8742022: Relands the following. First attempt was reverted because it broke (Closed)

Created:
9 years ago by sky

Modified:
9 years ago

Reviewers:
Ken Russell (switch to Gerrit), piman

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Relands the following. First attempt was reverted because it broke clang bot (too much inlined). TBR since this just moves some code to the .cc file. Makes TestWebGraphicsContext3D::initialize create a stub context and surface. This is needed otherwise we crash when code tries to access the current context. Also makes GLContextStub::MakeCurrent set itself as the current context. BUG=104360 TEST=none R=kbr@chromium.org,piman@chromium.org TBR=kbr@chromium.org,piman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112264

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+285 lines, -103 lines)			Patch
M	ui/gfx/compositor/compositor.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/compositor/test_web_graphics_context_3d.h	View	7 chunks	+56 lines, -100 lines	0 comments	Download
A	ui/gfx/compositor/test_web_graphics_context_3d.cc	View	1 chunk	+225 lines, -0 lines	0 comments	Download
M	ui/gfx/gl/gl_context.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_context_stub.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8742022/1

9 years ago (2011-11-30 17:32:51 UTC) #2

Change committed as 112264