Signed settings refactoring: Proper caching and more tests.

chrome/browser/chromeos/cros_settings.h

Index: chrome/browser/chromeos/cros_settings.h
diff --git a/chrome/browser/chromeos/cros_settings.h b/chrome/browser/chromeos/cros_settings.h
index c7f66d276ce0fcedd479f57912bee74fd6fb2d7e..a96bf3c7658b6ddf9c2c8cd8b0b9fc32002b4809 100644
--- a/chrome/browser/chromeos/cros_settings.h
+++ b/chrome/browser/chromeos/cros_settings.h
@@ -43,7 +43,7 @@ class CrosSettings : public base::NonThreadSafe {
   void FireObservers(const char* path);
 
   // Gets settings value of given |path| to |out_value|.
-  const base::Value* GetPref(const std::string& path) const;
+  base::Value* GetPref(const std::string& path) const;

[Mattias Nissler (ping if slow), 2011/11/30 11:22:44]

Why is this now non-const? From the rest of the code it looks like this actually
passes out ownership now. Are you sure this is a good thing to do?

[pastarmovj, 2011/11/30 17:21:16]

Changed as discussed offline.

 
   // Starts a fetch from the trusted store for the value of |path| if not loaded
   // yet. It will call the |callback| function upon completion if a new fetch
@@ -92,6 +92,8 @@ class CrosSettings : public base::NonThreadSafe {
   // Returns the provider that handles settings with the path or prefix.
   CrosSettingsProvider* GetProvider(const std::string& path) const;
 
+  void ReloadProviders() const;

[Mattias Nissler (ping if slow), 2011/11/30 11:22:44]

Needs a comment. What does it do? Recreate the providers? Tell all providers to
refetch their settings from the backing store?

[pastarmovj, 2011/11/30 17:21:16]

Sorry my bad I forgot to comment that one. Done.

+
  private:
   // List of ChromeOS system settings providers.
   std::vector<CrosSettingsProvider*> providers_;