Signed settings refactoring: Proper caching and more tests.

chrome/browser/chromeos/cros_settings.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_
 #define CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 25 matching lines @@
 
   // Sets |in_value| to given |path| in cros settings.
   void Set(const std::string& path, const base::Value& in_value);
 
   // Fires system setting change notification.
   // TODO(pastarmovj): Consider to remove this function from the public
   // interface.
   void FireObservers(const char* path);
 
   // Gets settings value of given |path| to |out_value|.
-  const base::Value* GetPref(const std::string& path) const;
+  base::Value* GetPref(const std::string& path) const;

[Mattias Nissler (ping if slow), 2011/11/30 11:22:44]

Why is this now non-const? From the rest of the code it looks like this actually
passes out ownership now. Are you sure this is a good thing to do?

[pastarmovj, 2011/11/30 17:21:16]

Changed as discussed offline.

 
   // Starts a fetch from the trusted store for the value of |path| if not loaded
   // yet. It will call the |callback| function upon completion if a new fetch
   // was needed in which case the return value is false. Else it will return
   // true and won't call the |callback|.
   bool GetTrusted(const std::string& path,
                   const base::Closure& callback) const;
 
   // Convenience forms of Set().  These methods will replace any existing
   // value at that path, even if it has a different type.
@@ skipping 28 matching lines @@
   // If the pref at the given path changes, we call the observer's Observe
   // method with PREF_CHANGED.
   void AddSettingsObserver(const char* path,
                            content::NotificationObserver* obs);
   void RemoveSettingsObserver(const char* path,
                               content::NotificationObserver* obs);
 
   // Returns the provider that handles settings with the path or prefix.
   CrosSettingsProvider* GetProvider(const std::string& path) const;
 
+  void ReloadProviders() const;

[Mattias Nissler (ping if slow), 2011/11/30 11:22:44]

Needs a comment. What does it do? Recreate the providers? Tell all providers to
refetch their settings from the backing store?

[pastarmovj, 2011/11/30 17:21:16]

Sorry my bad I forgot to comment that one. Done.

+
  private:
   // List of ChromeOS system settings providers.
   std::vector<CrosSettingsProvider*> providers_;
 
   // A map from settings names to a list of observers. Observers get fired in
   // the order they are added.
   typedef ObserverList<content::NotificationObserver> NotificationObserverList;
   typedef base::hash_map<std::string, NotificationObserverList*>
       SettingsObserverMap;
   SettingsObserverMap settings_observers_;
 
   CrosSettings();
   ~CrosSettings();
   friend struct base::DefaultLazyInstanceTraits<CrosSettings>;
 
   DISALLOW_COPY_AND_ASSIGN(CrosSettings);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_