Signed settings refactoring: Proper caching and more tests.

chrome/browser/chromeos/cros_settings_provider.h

Index: chrome/browser/chromeos/cros_settings_provider.h
diff --git a/chrome/browser/chromeos/cros_settings_provider.h b/chrome/browser/chromeos/cros_settings_provider.h
index c050092b22543076dd79392c880f6bccc48c1c29..0fef52cf0915488bc850fb6469686b49e8733fbf 100644
--- a/chrome/browser/chromeos/cros_settings_provider.h
+++ b/chrome/browser/chromeos/cros_settings_provider.h
@@ -23,18 +23,21 @@ class CrosSettingsProvider {
   void Set(const std::string& path, const base::Value& in_value);
 
   // Gets settings value of given |path| to |out_value|.
-  virtual const base::Value* Get(const std::string& path) const = 0;
+  virtual base::Value* Get(const std::string& path) const = 0;

[Mattias Nissler (ping if slow), 2011/11/30 11:22:44]

Why is this no longer const? I hope it doesn't return a copy?

[pastarmovj, 2011/11/30 17:21:16]

Const again.

 
   // Starts a fetch from the trusted store for the value of |path| if not loaded
   // yet. It will call the |callback| function upon completion if a new fetch
   // was needed in which case the return value is false. Else it will return
   // true and won't call the |callback|.
   virtual bool GetTrusted(const std::string& path,
-                          const base::Closure& callback) const = 0;
+                          const base::Closure& callback) = 0;
 
-  // Gets the namespace prefix provided by this provider
+  // Gets the namespace prefix provided by this provider.
   virtual bool HandlesSetting(const std::string& path) const = 0;
 
+  // Reloads the caches if the provider has any.
+  virtual void Reload() = 0;
+
  private:
   // Does the real job for Set().
   virtual void DoSet(const std::string& path,