Eliminate use of assignments to innerHTML in File Browser

Eliminate use of assignments to innerHTML in File Browser

Also removed obsolete files to minimize security audit efforts.

BUG=chromium-os:23502
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112215

[Vladislav Kaznacheev, 2011-11-29 10:38:23]

Hi Jim,

I have replace all empty-string assignments with DOM removal code.

I cannot come up with a good replacement for a single non-trivial assignment.
The reason it is done this way is that the html is localized, so I cannot easily
create the html markup in the code. This seems to be a fairly common practice
though (only the <strong> tag occures 50+ times in generated_resources.grd).

[dgozman, 2011-11-29 11:31:03]

LGTM

[commit-bot: I haz the power, 2011-11-29 19:13:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8727028/1

[commit-bot: I haz the power, 2011-11-29 19:45:08]

Try job failure for 8727028-1 (retry) on linux_clang for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[arv (Not doing code reviews), 2011-11-29 22:53:27]

http://codereview.chromium.org/8727028/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/8727028/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:437: function
removeChildren(element) {
element.textContent = '';

[Vladislav Kaznacheev, 2011-11-30 10:06:10]

Great idea! Done.
On 2011/11/29 22:53:27, arv wrote:
>
http://codereview.chromium.org/8727028/diff/1/chrome/browser/resources/file_m...
> File chrome/browser/resources/file_manager/js/file_manager.js (right):
> 
>
http://codereview.chromium.org/8727028/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:437: function
> removeChildren(element) {
> element.textContent = '';

[Vladislav Kaznacheev, 2011-11-30 10:06:44]

I made some changes, PTAL.

[dgozman, 2011-11-30 11:27:19]

LGTM

[commit-bot: I haz the power, 2011-11-30 12:08:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8727028/10001

[commit-bot: I haz the power, 2011-11-30 13:56:38]

Change committed as 112215