chrome/browser/resources/file_manager/js/image_editor/gallery.js - Issue 8727028: Eliminate use of assignments to innerHTML in File Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/js/image_editor/gallery.js

Issue 8727028: Eliminate use of assignments to innerHTML in File Browser (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Deleted another redundant file Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/file_manager/js/image_editor/gallery.js

diff --git a/chrome/browser/resources/file_manager/js/image_editor/gallery.js b/chrome/browser/resources/file_manager/js/image_editor/gallery.js

index 5e820fa9a60a4ba868817709f4345ebfd08bf444..82d6abc2eb7d1261e19bdfcbf0908951f1d985af 100644

--- a/chrome/browser/resources/file_manager/js/image_editor/gallery.js

+++ b/chrome/browser/resources/file_manager/js/image_editor/gallery.js

@@ -46,7 +46,7 @@ Gallery.prototype = { __proto__: RibbonClient.prototype };

Gallery.open = function(parentDirEntry, items, selectedItem,

closeCallback, metadataProvider, shareActions, displayStringFunction) {

var container = document.querySelector('.gallery');

- container.innerHTML = '';

+ ImageUtil.removeChildren(container);

var gallery = new Gallery(container, closeCallback, metadataProvider,

shareActions, displayStringFunction);

gallery.load(parentDirEntry, items, selectedItem);