chrome/browser/resources/file_manager/js/image_editor/image_editor.js - Issue 8727028: Eliminate use of assignments to innerHTML in File Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/js/image_editor/image_editor.js

Issue 8727028: Eliminate use of assignments to innerHTML in File Browser (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Deleted another redundant file Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/file_manager/js/image_editor/image_editor.html ('k') | chrome/browser/resources/file_manager/js/image_editor/image_util.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/file_manager/js/image_editor/image_editor.js

diff --git a/chrome/browser/resources/file_manager/js/image_editor/image_editor.js b/chrome/browser/resources/file_manager/js/image_editor/image_editor.js

index e8a79797fc59f08f0679852c42fc103ec2281307..723ffeafade02ab0cd01759cc1e71300763a5732 100644

--- a/chrome/browser/resources/file_manager/js/image_editor/image_editor.js

+++ b/chrome/browser/resources/file_manager/js/image_editor/image_editor.js

@@ -20,7 +20,7 @@ function ImageEditor(

this.modes_ = modes;

this.displayStringFunction_ = displayStringFunction;

- this.container_.innerHTML = '';

+ ImageUtil.removeChildren(this.container_);

var document = this.container_.ownerDocument;

@@ -658,7 +658,7 @@ ImageEditor.Toolbar = function(parent, displayStringFunction, updateCallback) {

};

ImageEditor.Toolbar.prototype.clear = function() {

- this.wrapper_.innerHTML = '';

+ ImageUtil.removeChildren(this.wrapper_);

};

ImageEditor.Toolbar.prototype.create_ = function(tagName) {