Disable network "Connect" dialog UI in case of policy-managed networks.

Disable network "Connect" dialog UI in case of policy-managed networks.

BUG=chromium-os:23124
TEST=Network configuration continues to work, options are locked down for policy-configured networks.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112508

[Mattias Nissler (ping if slow), 2011-11-28 20:02:23]

Hey Steven, this is the last one for now :)

[stevenjb, 2011-11-29 07:26:38]

I'm going to wait until we are happy with the other CL to review this, but
looking at all the new accessors to *Network, I would really like to see us go
in a direction that keeps that code in the UI and out of Network /
NetworkLibrary.

[Mattias Nissler (ping if slow), 2011-11-29 14:53:34]

On 2011/11/29 07:26:38, Steven Bennetts wrote:
> I'm going to wait until we are happy with the other CL to review this, but
> looking at all the new accessors to *Network, I would really like to see us go
> in a direction that keeps that code in the UI and out of Network /
> NetworkLibrary.

OK, I rebased this CL onto http://codereview.chromium.org/8728030/. Let's first
discuss the latter though.

[stevenjb, 2011-11-29 17:58:27]

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
File chrome/browser/chromeos/options/network_config_view.cc (right):

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/network_config_view.cc:213: return;
See my comments in 8728030, but I think we should either always store
controller_, or instead add a managed() accessor to ui_data and set a boolean
here.

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/network_config_view.cc:251: // Disable
|image_view_|, so mouse events bubble up.
nit: "bubble up" may not be well understood :) Perhaps "propagate to the parent"
or "get passed to the parent"

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
File chrome/browser/chromeos/options/vpn_config_view.cc (right):

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/vpn_config_view.cc:543:
username_textfield_->SetEnabled(username_ui_data_.editable());
Hmm, this looks much better than comparing the enum value. I'm now convinced we
should just use accessors instead :)

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/wifi_config_view.cc:927:
NetworkPropertyUIData::CONTROLLER_POLICY) {
I think this should definitely be either !editable() or managed() (or somesuch)
to be consistent.

[Mattias Nissler (ping if slow), 2011-11-29 21:29:39]

And this one is also rebased and in shape for another review.

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
File chrome/browser/chromeos/options/network_config_view.cc (right):

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/network_config_view.cc:213: return;
On 2011/11/29 17:58:28, Steven Bennetts wrote:
> See my comments in 8728030, but I think we should either always store
> controller_, or instead add a managed() accessor to ui_data and set a boolean
> here.

Done.

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/network_config_view.cc:251: // Disable
|image_view_|, so mouse events bubble up.
On 2011/11/29 17:58:28, Steven Bennetts wrote:
> nit: "bubble up" may not be well understood :) Perhaps "propagate to the
parent"
> or "get passed to the parent"

Done.

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
File chrome/browser/chromeos/options/vpn_config_view.cc (right):

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/vpn_config_view.cc:543:
username_textfield_->SetEnabled(username_ui_data_.editable());
On 2011/11/29 17:58:28, Steven Bennetts wrote:
> Hmm, this looks much better than comparing the enum value. I'm now convinced
we
> should just use accessors instead :)

Done.

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

http://codereview.chromium.org/8726008/diff/3002/chrome/browser/chromeos/opti...
chrome/browser/chromeos/options/wifi_config_view.cc:927:
NetworkPropertyUIData::CONTROLLER_POLICY) {
On 2011/11/29 17:58:28, Steven Bennetts wrote:
> I think this should definitely be either !editable() or managed() (or
somesuch)
> to be consistent.

Done.

[stevenjb, 2011-11-30 17:44:26]

lgtm

[commit-bot: I haz the power, 2011-12-01 18:32:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/8726008/10001

[commit-bot: I haz the power, 2011-12-01 20:07:43]

Change committed as 112508