Disable network "Connect" dialog UI in case of policy-managed networks.

chrome/browser/chromeos/options/wifi_config_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/options/wifi_config_view.h"
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/network_library.h"
@@ skipping 354 matching lines @@
 }
 
 void WifiConfigView::RefreshEapFields() {
   DCHECK(cert_library_);
   int selected = eap_method_combobox_->selected_item();
 
   // If EAP method changes, the phase 2 auth choices may have changed also.
   phase_2_auth_combobox_->ModelChanged();
   phase_2_auth_combobox_->SetSelectedItem(0);
   phase_2_auth_combobox_->SetEnabled(
-      phase_2_auth_combobox_->model()->GetItemCount() > 1);
+      phase_2_auth_combobox_->model()->GetItemCount() > 1 &&
+      phase_2_auth_ui_data_.editable());
   phase_2_auth_label_->SetEnabled(phase_2_auth_combobox_->IsEnabled());
 
   // No password for EAP-TLS
   passphrase_textfield_->SetEnabled(selected != EAP_METHOD_INDEX_NONE &&
-                                    selected != EAP_METHOD_INDEX_TLS);
+                                    selected != EAP_METHOD_INDEX_TLS &&
+                                    passphrase_ui_data_.editable());
   passphrase_label_->SetEnabled(passphrase_textfield_->IsEnabled());
   if (!passphrase_textfield_->IsEnabled())
     passphrase_textfield_->SetText(string16());
 
   // User certs only for EAP-TLS
   bool certs_loading = !cert_library_->CertificatesLoaded();
   bool user_cert_enabled = (selected == EAP_METHOD_INDEX_TLS);
   user_cert_label_->SetEnabled(user_cert_enabled);
   bool have_user_certs = !certs_loading && HaveUserCerts();
-  user_cert_combobox_->SetEnabled(user_cert_enabled && have_user_certs);
+  user_cert_combobox_->SetEnabled(user_cert_enabled &&
+                                  have_user_certs &&
+                                  user_cert_ui_data_.editable());
   user_cert_combobox_->ModelChanged();
   user_cert_combobox_->SetSelectedItem(0);
 
   // No server CA certs for LEAP
   bool ca_cert_enabled =
       (selected != EAP_METHOD_INDEX_NONE && selected != EAP_METHOD_INDEX_LEAP);
   server_ca_cert_label_->SetEnabled(ca_cert_enabled);
-  server_ca_cert_combobox_->SetEnabled(ca_cert_enabled && !certs_loading);
+  server_ca_cert_combobox_->SetEnabled(ca_cert_enabled &&
+                                       !certs_loading &&
+                                       server_ca_cert_ui_data_.editable());
   server_ca_cert_combobox_->ModelChanged();
   server_ca_cert_combobox_->SetSelectedItem(0);
 
   // No anonymous identity if no phase 2 auth.
   identity_anonymous_textfield_->SetEnabled(
-      phase_2_auth_combobox_->IsEnabled());
+      phase_2_auth_combobox_->IsEnabled() &&
+      identity_anonymous_ui_data_.editable());
   identity_anonymous_label_->SetEnabled(
       identity_anonymous_textfield_->IsEnabled());
   if (!identity_anonymous_textfield_->IsEnabled())
     identity_anonymous_textfield_->SetText(string16());
 
   RefreshShareCheckbox();
 }
 
 void WifiConfigView::RefreshShareCheckbox() {
   if (!share_network_checkbox_)
@@ skipping 319 matching lines @@
 void WifiConfigView::Cancel() {
 }
 
 // This will initialize the view depending on if we have a wifi network or not.
 // And if we are doing simple password encryption or the more complicated
 // 802.1x encryption.
 // If we are creating the "Join other network..." dialog, we will allow user
 // to enter the data. And if they select the 802.1x encryption, we will show
 // the 802.1x fields.
 void WifiConfigView::Init(WifiNetwork* wifi, bool show_8021x) {
+  if (wifi) {
+    eap_method_ui_data_.UpdateFromNetwork(
+        wifi, NetworkUIData::kPropertyEAPMethod);
+    phase_2_auth_ui_data_.UpdateFromNetwork(
+        wifi, NetworkUIData::kPropertyEAPPhase2Auth);
+    user_cert_ui_data_.UpdateFromNetwork(
+        wifi, NetworkUIData::kPropertyEAPClientCertPkcs11Id);
+    server_ca_cert_ui_data_.UpdateFromNetwork(
+        wifi, NetworkUIData::kPropertyEAPServerCaCertNssNickname);
+    if (server_ca_cert_ui_data_.controller() !=
+        NetworkPropertyUIData::CONTROLLER_POLICY) {
+      server_ca_cert_ui_data_.UpdateFromNetwork(
+          wifi, NetworkUIData::kPropertyEAPUseSystemCAs);
+    }
+    identity_ui_data_.UpdateFromNetwork(
+        wifi, NetworkUIData::kPropertyEAPIdentity);
+    identity_anonymous_ui_data_.UpdateFromNetwork(
+        wifi, NetworkUIData::kPropertyEAPAnonymousIdentity);
+    save_credentials_ui_data_.UpdateFromNetwork(
+        wifi, NetworkUIData::kPropertySaveCredentials);
+    if (show_8021x) {
+      passphrase_ui_data_.UpdateFromNetwork(
+          wifi, NetworkUIData::kPropertyEAPPassphrase);
+    } else {
+      passphrase_ui_data_.UpdateFromNetwork(
+          wifi, NetworkUIData::kPropertyPassphrase);
+    }
+  }
+
   views::GridLayout* layout = views::GridLayout::CreatePanel(this);
   SetLayoutManager(layout);
 
   int column_view_set_id = 0;
   views::ColumnSet* column_set = layout->AddColumnSet(column_view_set_id);
   const int kPasswordVisibleWidth = 20;
   // Label
   column_set->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1,
                         views::GridLayout::USE_PREF, 0, 0);
   column_set->AddPaddingColumn(0, views::kRelatedControlSmallHorizontalSpacing);
   // Textfield, combobox.
   column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
                         views::GridLayout::USE_PREF, 0,
                         ChildNetworkConfigView::kInputFieldMinWidth);
   column_set->AddPaddingColumn(0, views::kRelatedControlSmallHorizontalSpacing);
-  // Password visible button
+  // Password visible button / policy indicator.
   column_set->AddColumn(views::GridLayout::CENTER, views::GridLayout::FILL, 1,
                         views::GridLayout::USE_PREF, 0, kPasswordVisibleWidth);
 
   // SSID input
   layout->StartRow(0, column_view_set_id);
   layout->AddView(new views::Label(l10n_util::GetStringUTF16(
       IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_NETWORK_ID)));
   if (!wifi) {
     ssid_textfield_ = new views::Textfield(views::Textfield::STYLE_DEFAULT);
     ssid_textfield_->SetController(this);
@@ skipping 25 matching lines @@
     // Setup a callback if certificates are yet to be loaded,
     if (!cert_library_->CertificatesLoaded())
       cert_library_->AddObserver(this);
 
     // EAP method
     layout->StartRow(0, column_view_set_id);
     layout->AddView(new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_EAP_METHOD)));
     eap_method_combobox_ = new views::Combobox(new EAPMethodComboboxModel());
     eap_method_combobox_->set_listener(this);
+    eap_method_combobox_->SetEnabled(eap_method_ui_data_.editable());
     layout->AddView(eap_method_combobox_);
+    layout->AddView(new ControlledSettingIndicatorView(eap_method_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
     // Phase 2 authentication
     layout->StartRow(0, column_view_set_id);
     phase_2_auth_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_PHASE_2_AUTH));
     layout->AddView(phase_2_auth_label_);
     phase_2_auth_combobox_ = new views::Combobox(
         new Phase2AuthComboboxModel(eap_method_combobox_));
     phase_2_auth_label_->SetEnabled(false);
     phase_2_auth_combobox_->SetEnabled(false);
     phase_2_auth_combobox_->set_listener(this);
     layout->AddView(phase_2_auth_combobox_);
+    layout->AddView(new ControlledSettingIndicatorView(phase_2_auth_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
     // Server CA certificate
     layout->StartRow(0, column_view_set_id);
     server_ca_cert_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_SERVER_CA));
     layout->AddView(server_ca_cert_label_);
     server_ca_cert_combobox_ = new ComboboxWithWidth(
         new ServerCACertComboboxModel(cert_library_),
         ChildNetworkConfigView::kInputFieldMinWidth);
     server_ca_cert_label_->SetEnabled(false);
     server_ca_cert_combobox_->SetEnabled(false);
     server_ca_cert_combobox_->set_listener(this);
     layout->AddView(server_ca_cert_combobox_);
+    layout->AddView(
+        new ControlledSettingIndicatorView(server_ca_cert_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
     // User certificate
     layout->StartRow(0, column_view_set_id);
     user_cert_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT));
     layout->AddView(user_cert_label_);
     user_cert_combobox_ = new views::Combobox(
         new UserCertComboboxModel(cert_library_));
     user_cert_label_->SetEnabled(false);
     user_cert_combobox_->SetEnabled(false);
     user_cert_combobox_->set_listener(this);
     layout->AddView(user_cert_combobox_);
+    layout->AddView(new ControlledSettingIndicatorView(user_cert_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
     // Identity
     layout->StartRow(0, column_view_set_id);
     identity_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_IDENTITY));
     layout->AddView(identity_label_);
     identity_textfield_ = new views::Textfield(
         views::Textfield::STYLE_DEFAULT);
     identity_textfield_->SetController(this);
     if (wifi && !wifi->identity().empty())
       identity_textfield_->SetText(UTF8ToUTF16(wifi->identity()));
+    identity_textfield_->SetEnabled(identity_ui_data_.editable());
     layout->AddView(identity_textfield_);
+    layout->AddView(new ControlledSettingIndicatorView(identity_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   }
 
   // Passphrase input
   layout->StartRow(0, column_view_set_id);
   int label_text_id = IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_PASSPHRASE;
   passphrase_label_ = new views::Label(
       l10n_util::GetStringUTF16(label_text_id));
   layout->AddView(passphrase_label_);
   passphrase_textfield_ = new views::Textfield(
       views::Textfield::STYLE_PASSWORD);
   passphrase_textfield_->SetController(this);
   if (wifi && !wifi->GetPassphrase().empty())
     passphrase_textfield_->SetText(UTF8ToUTF16(wifi->GetPassphrase()));
   // Disable passphrase input initially for other network.
   if (!wifi) {
     passphrase_label_->SetEnabled(false);
     passphrase_textfield_->SetEnabled(false);
   }
   passphrase_textfield_->SetAccessibleName(l10n_util::GetStringUTF16(
       label_text_id));
   layout->AddView(passphrase_textfield_);
-  // Password visible button.
-  passphrase_visible_button_ = new views::ToggleImageButton(this);
-  passphrase_visible_button_->SetTooltipText(
-      l10n_util::GetStringUTF16(
-          IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_PASSPHRASE_SHOW));
-  passphrase_visible_button_->SetToggledTooltipText(
-      l10n_util::GetStringUTF16(
-          IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_PASSPHRASE_HIDE));
-  passphrase_visible_button_->SetImage(
-      views::ImageButton::BS_NORMAL,
-      ResourceBundle::GetSharedInstance().
-      GetBitmapNamed(IDR_NETWORK_SHOW_PASSWORD_OFF));
-  passphrase_visible_button_->SetImage(
-      views::ImageButton::BS_HOT,
-      ResourceBundle::GetSharedInstance().
-      GetBitmapNamed(IDR_NETWORK_SHOW_PASSWORD_HOVER));
-  passphrase_visible_button_->SetToggledImage(
-      views::ImageButton::BS_NORMAL,
-      ResourceBundle::GetSharedInstance().
-      GetBitmapNamed(IDR_NETWORK_SHOW_PASSWORD_ON));
-  passphrase_visible_button_->SetImageAlignment(
-      views::ImageButton::ALIGN_CENTER, views::ImageButton::ALIGN_MIDDLE);
-  layout->AddView(passphrase_visible_button_);
+
+  if (passphrase_ui_data_.controller() ==
+      NetworkPropertyUIData::CONTROLLER_POLICY) {

[stevenjb, 2011/11/29 17:58:28]

I think this should definitely be either !editable() or managed() (or somesuch)
to be consistent.

[Mattias Nissler (ping if slow), 2011/11/29 21:29:39]

Done.

+    layout->AddView(new ControlledSettingIndicatorView(passphrase_ui_data_));
+  } else {
+    // Password visible button.
+    passphrase_visible_button_ = new views::ToggleImageButton(this);
+    passphrase_visible_button_->SetTooltipText(
+        l10n_util::GetStringUTF16(
+            IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_PASSPHRASE_SHOW));
+    passphrase_visible_button_->SetToggledTooltipText(
+        l10n_util::GetStringUTF16(
+            IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_PASSPHRASE_HIDE));
+    passphrase_visible_button_->SetImage(
+        views::ImageButton::BS_NORMAL,
+        ResourceBundle::GetSharedInstance().
+        GetBitmapNamed(IDR_NETWORK_SHOW_PASSWORD_OFF));
+    passphrase_visible_button_->SetImage(
+        views::ImageButton::BS_HOT,
+        ResourceBundle::GetSharedInstance().
+        GetBitmapNamed(IDR_NETWORK_SHOW_PASSWORD_HOVER));
+    passphrase_visible_button_->SetToggledImage(
+        views::ImageButton::BS_NORMAL,
+        ResourceBundle::GetSharedInstance().
+        GetBitmapNamed(IDR_NETWORK_SHOW_PASSWORD_ON));
+    passphrase_visible_button_->SetImageAlignment(
+        views::ImageButton::ALIGN_CENTER, views::ImageButton::ALIGN_MIDDLE);
+    layout->AddView(passphrase_visible_button_);
+  }
+
   layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
   if (show_8021x) {
     // Anonymous identity
     layout->StartRow(0, column_view_set_id);
     identity_anonymous_label_ =
         new views::Label(l10n_util::GetStringUTF16(
             IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_IDENTITY_ANONYMOUS));
     layout->AddView(identity_anonymous_label_);
     identity_anonymous_textfield_ = new views::Textfield(
         views::Textfield::STYLE_DEFAULT);
     identity_anonymous_label_->SetEnabled(false);
     identity_anonymous_textfield_->SetEnabled(false);
     identity_anonymous_textfield_->SetController(this);
     layout->AddView(identity_anonymous_textfield_);
+    layout->AddView(
+        new ControlledSettingIndicatorView(identity_anonymous_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   }
 
   // Checkboxes.
 
   // Save credentials
   if (show_8021x) {
     layout->StartRow(0, column_view_set_id);
     save_credentials_checkbox_ = new views::Checkbox(
         l10n_util::GetStringUTF16(
             IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_SAVE_CREDENTIALS));
+    save_credentials_checkbox_->SetEnabled(
+        save_credentials_ui_data_.editable());
     layout->SkipColumns(1);
     layout->AddView(save_credentials_checkbox_);
+    layout->AddView(
+        new ControlledSettingIndicatorView(save_credentials_ui_data_));
   }
 
   // Share network
   if (!wifi ||
       (wifi->profile_type() == PROFILE_NONE &&
        wifi->IsPassphraseRequired() &&
        !wifi->RequiresUserProfile())) {
     layout->StartRow(0, column_view_set_id);
     share_network_checkbox_ = new views::Checkbox(
         l10n_util::GetStringUTF16(
@@ skipping 132 matching lines @@
   // Set focus to a reasonable widget, depending on what we're showing.
   if (ssid_textfield_)
     ssid_textfield_->RequestFocus();
   else if (eap_method_combobox_)
     eap_method_combobox_->RequestFocus();
   else if (passphrase_textfield_ && passphrase_textfield_->IsEnabled())
     passphrase_textfield_->RequestFocus();
 }
 
 }  // namespace chromeos