Disable network "Connect" dialog UI in case of policy-managed networks.

chrome/browser/chromeos/options/vpn_config_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/options/vpn_config_view.h"
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/common/net/x509_certificate_model.h"
@@ skipping 351 matching lines @@
     return std::string();  // "None installed"
   } else {
     // Certificates are listed in the order they appear in the model.
     int selected =
         user_cert_combobox_ ? user_cert_combobox_->selected_item() : 0;
     return cert_library_->GetUserCertificates().GetPkcs11IdAt(selected);
   }
 }
 
 void VPNConfigView::Init(VirtualNetwork* vpn) {
+  if (vpn) {
+    ca_cert_ui_data_.UpdateFromNetwork(
+        vpn, NetworkUIData::kPropertyVPNCaCertNss);
+    psk_passphrase_ui_data_.UpdateFromNetwork(
+        vpn, NetworkUIData::kPropertyVPNPskPassphrase);
+    user_cert_ui_data_.UpdateFromNetwork(
+        vpn, NetworkUIData::kPropertyVPNClientCertId);
+    username_ui_data_.UpdateFromNetwork(
+        vpn, NetworkUIData::kPropertyVPNUsername);
+    user_passphrase_ui_data_.UpdateFromNetwork(
+        vpn, NetworkUIData::kPropertyVPNUserPassphrase);
+    group_name_ui_data_.UpdateFromNetwork(
+        vpn, NetworkUIData::kPropertyVPNGroupName);
+  }
+
   views::GridLayout* layout = views::GridLayout::CreatePanel(this);
   SetLayoutManager(layout);
 
   // VPN may require certificates, so always set the library and observe.
   cert_library_ = chromeos::CrosLibrary::Get()->GetCertLibrary();
 
   // Setup a callback if certificates are yet to be loaded.
   if (!cert_library_->CertificatesLoaded())
     cert_library_->AddObserver(this);
 
   int column_view_set_id = 0;
   views::ColumnSet* column_set = layout->AddColumnSet(column_view_set_id);
   // Label.
   column_set->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1,
                         views::GridLayout::USE_PREF, 0, 0);
   column_set->AddPaddingColumn(0, views::kRelatedControlSmallHorizontalSpacing);
   // Textfield, combobox.
   column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
                         views::GridLayout::USE_PREF, 0,
                         ChildNetworkConfigView::kInputFieldMinWidth);
   column_set->AddPaddingColumn(0, views::kRelatedControlSmallHorizontalSpacing);
+  // Policy indicator.
+  column_set->AddColumn(views::GridLayout::CENTER, views::GridLayout::CENTER, 0,
+                        views::GridLayout::USE_PREF, 0, 0);
 
   // Initialize members.
   service_text_modified_ = false;
   if (vpn) {
     provider_type_ = vpn->provider_type();
     // Sets enable_* based on the provider type which we use to control
     // which controls to make visible.
     UpdateControlsToEnable();
   } else {
     // Set the default provider type.
@@ skipping 61 matching lines @@
     layout->StartRow(0, column_view_set_id);
     psk_passphrase_label_ =  new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_PSK_PASSPHRASE));
     layout->AddView(psk_passphrase_label_);
     psk_passphrase_textfield_ = new views::Textfield(
         views::Textfield::STYLE_PASSWORD);
     psk_passphrase_textfield_->SetController(this);
     if (vpn && !vpn->psk_passphrase().empty())
       psk_passphrase_textfield_->SetText(UTF8ToUTF16(vpn->psk_passphrase()));
     layout->AddView(psk_passphrase_textfield_);
+    layout->AddView(
+        new ControlledSettingIndicatorView(psk_passphrase_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   } else {
     psk_passphrase_label_ = NULL;
     psk_passphrase_textfield_ = NULL;
   }
 
   // Server CA certificate
   // Only provide Server CA when configuring a new VPN.
   if (!vpn) {
     layout->StartRow(0, column_view_set_id);
     server_ca_cert_label_ =
         new views::Label(l10n_util::GetStringUTF16(
             IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_SERVER_CA));
     layout->AddView(server_ca_cert_label_);
     ServerCACertComboboxModel* server_ca_cert_model =
         new ServerCACertComboboxModel(cert_library_);
     server_ca_cert_combobox_ = new views::Combobox(server_ca_cert_model);
     layout->AddView(server_ca_cert_combobox_);
+    layout->AddView(new ControlledSettingIndicatorView(ca_cert_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   } else {
     server_ca_cert_label_ = NULL;
     server_ca_cert_combobox_ = NULL;
   }
 
   // User certificate label and input.
   if (enable_user_cert_) {
     layout->StartRow(0, column_view_set_id);
     user_cert_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_USER_CERT));
     layout->AddView(user_cert_label_);
     UserCertComboboxModel* user_cert_model =
         new UserCertComboboxModel(cert_library_);
     user_cert_combobox_ = new views::Combobox(user_cert_model);
     user_cert_combobox_->set_listener(this);
     layout->AddView(user_cert_combobox_);
+    layout->AddView(new ControlledSettingIndicatorView(user_cert_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   } else {
     user_cert_label_ = NULL;
     user_cert_combobox_ = NULL;
   }
 
   // Username label and input.
   layout->StartRow(0, column_view_set_id);
   layout->AddView(new views::Label(l10n_util::GetStringUTF16(
       IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_USERNAME)));
   username_textfield_ = new views::Textfield(views::Textfield::STYLE_DEFAULT);
   username_textfield_->SetController(this);
+  username_textfield_->SetEnabled(username_ui_data_.editable());

[stevenjb, 2011/11/29 17:58:28]

Hmm, this looks much better than comparing the enum value. I'm now convinced we
should just use accessors instead :)

[Mattias Nissler (ping if slow), 2011/11/29 21:29:39]

Done.

   if (vpn && !vpn->username().empty())
     username_textfield_->SetText(UTF8ToUTF16(vpn->username()));
   layout->AddView(username_textfield_);
+  layout->AddView(new ControlledSettingIndicatorView(username_ui_data_));
   layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
   // User passphrase label, input and visble button.
   layout->StartRow(0, column_view_set_id);
   layout->AddView(new views::Label(l10n_util::GetStringUTF16(
       IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_USER_PASSPHRASE)));
   user_passphrase_textfield_ = new views::Textfield(
       views::Textfield::STYLE_PASSWORD);
   user_passphrase_textfield_->SetController(this);
+  user_passphrase_textfield_->SetEnabled(user_passphrase_ui_data_.editable());
   if (vpn && !vpn->user_passphrase().empty())
     user_passphrase_textfield_->SetText(UTF8ToUTF16(vpn->user_passphrase()));
   layout->AddView(user_passphrase_textfield_);
+  layout->AddView(new ControlledSettingIndicatorView(user_passphrase_ui_data_));
   layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
   // OTP label and input.
   if (enable_otp_) {
     layout->StartRow(0, column_view_set_id);
     otp_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_OTP));
     layout->AddView(otp_label_);
     otp_textfield_ = new views::Textfield(views::Textfield::STYLE_DEFAULT);
     otp_textfield_->SetController(this);
@@ skipping 14 matching lines @@
     layout->StartRow(0, column_view_set_id);
     group_name_label_ = new views::Label(l10n_util::GetStringUTF16(
         IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_GROUP_NAME));
     layout->AddView(group_name_label_);
     group_name_textfield_ =
         new views::Textfield(views::Textfield::STYLE_DEFAULT);
     group_name_textfield_->SetController(this);
     if (vpn && !vpn->group_name().empty())
       group_name_textfield_->SetText(UTF8ToUTF16(vpn->group_name()));
     layout->AddView(group_name_textfield_);
+    layout->AddView(new ControlledSettingIndicatorView(group_name_ui_data_));
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   } else {
     group_name_label_ = NULL;
     group_name_textfield_ = NULL;
   }
 
   // Error label.
   layout->StartRow(0, column_view_set_id);
   layout->SkipColumns(1);
   error_label_ = new views::Label();
@@ skipping 75 matching lines @@
       break;
   }
 }
 
 void VPNConfigView::UpdateControls() {
   UpdateControlsToEnable();
 
   if (psk_passphrase_label_)
     psk_passphrase_label_->SetEnabled(enable_psk_passphrase_);
   if (psk_passphrase_textfield_)
-    psk_passphrase_textfield_->SetEnabled(enable_psk_passphrase_);
+    psk_passphrase_textfield_->SetEnabled(enable_psk_passphrase_ &&
+                                          psk_passphrase_ui_data_.editable());
 
   if (user_cert_label_)
     user_cert_label_->SetEnabled(enable_user_cert_);
   if (user_cert_combobox_)
-    user_cert_combobox_->SetEnabled(enable_user_cert_);
+    user_cert_combobox_->SetEnabled(enable_user_cert_ &&
+                                    user_cert_ui_data_.editable());
 
   if (server_ca_cert_label_)
     server_ca_cert_label_->SetEnabled(enable_server_ca_cert_);
   if (server_ca_cert_combobox_)
-    server_ca_cert_combobox_->SetEnabled(enable_server_ca_cert_);
+    server_ca_cert_combobox_->SetEnabled(enable_server_ca_cert_ &&
+                                         ca_cert_ui_data_.editable());
 
   if (otp_label_)
     otp_label_->SetEnabled(enable_otp_);
   if (otp_textfield_)
     otp_textfield_->SetEnabled(enable_otp_);
 
   if (group_name_label_)
     group_name_label_->SetEnabled(enable_group_name_);
   if (group_name_textfield_)
-    group_name_textfield_->SetEnabled(enable_group_name_);
+    group_name_textfield_->SetEnabled(enable_group_name_ &&
+                                      group_name_ui_data_.editable());
 }
 
 void VPNConfigView::UpdateErrorLabel() {
   NetworkLibrary* cros = CrosLibrary::Get()->GetNetworkLibrary();
 
   // Error message.
   std::string error_msg;
   if (UserCertRequired() && cert_library_->CertificatesLoaded()) {
     if (!HaveUserCerts()) {
       error_msg = l10n_util::GetStringUTF8(
@@ skipping 55 matching lines @@
     return std::string();
   std::string untrimmed = UTF16ToUTF8(textfield->text());
   if (!trim_whitespace)
     return untrimmed;
   std::string result;
   TrimWhitespaceASCII(untrimmed, TRIM_ALL, &result);
   return result;
 }
 
 }  // namespace chromeos