Issue 8725013: Improve ExtensionBrowserTest. Part of moving ExtensionService to use ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8725013: Improve ExtensionBrowserTest. Part of moving ExtensionService to use ExtensionSet. (Closed)

Created:
9 years ago by Yoyo Zhou

Modified:
9 years ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve ExtensionBrowserTest. Part of moving ExtensionService to use ExtensionSet. - When installing CRX, observe CRX_INSTALLER_DONE notification, using that to get the ID of the installed extension. - Clean up ExtensionManagementTest to use the returned Extension instead of at(). - Use EXPECT in helper InstallExtension functions. BUG=104091, 105728 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112042

Patch Set 1 #

Patch Set 2 : :) #

Patch Set 3 : unit #

Patch Set 4 : fix tests #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -157 lines)			Patch
M	chrome/browser/extensions/crx_installer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer_browsertest.cc	View	1 2 3	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.h	View	1	3 chunks	+22 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.cc	View	1 2 3	5 chunks	+37 lines, -33 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api_browsertest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_management_browsertest.cc	View	1	16 chunks	+86 lines, -92 lines	0 comments	Download
M	chrome/browser/extensions/extension_updater_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

shrug, lgtm

Expand Messages | Collapse Messages