chrome/browser/extensions/extension_management_api_browsertest.cc - Issue 8725013: Improve ExtensionBrowserTest. Part of moving ExtensionService to use ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_api_browsertest.cc

Issue 8725013: Improve ExtensionBrowserTest. Part of moving ExtensionService to use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tests Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_browsertest.cc ('k') | chrome/browser/extensions/extension_management_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_management_api_browsertest.cc

diff --git a/chrome/browser/extensions/extension_management_api_browsertest.cc b/chrome/browser/extensions/extension_management_api_browsertest.cc

index 697c35ec2b9675394750d1f4ee5d8920faf1fb22..c226902cb4f997eef6500dee84b244670264dd76 100644

--- a/chrome/browser/extensions/extension_management_api_browsertest.cc

+++ b/chrome/browser/extensions/extension_management_api_browsertest.cc

@@ -70,7 +70,7 @@ class ExtensionManagementApiEscalationTest : public ExtensionBrowserTest {

EXPECT_TRUE(service->GetExtensionById(kId, false) != NULL);

// Update to a high-permission version - it should get disabled.

- EXPECT_TRUE(UpdateExtension(

+ EXPECT_FALSE(UpdateExtension(

kId, test_data_dir_.AppendASCII("permissions-high-v2.crx"), -1));

EXPECT_TRUE(service->GetExtensionById(kId, false) == NULL);

EXPECT_TRUE(service->GetExtensionById(kId, true) != NULL);