Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2067)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 8725013: Improve ExtensionBrowserTest. Part of moving ExtensionService to use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index 14153b1ac740a1546b2a9f8beb05ad513208d47e..3009d0d4e3887d974839a40b2aff32c4713c98d9 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -75,9 +75,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, Whitelisting) {
#endif // !defined(OS_CHROMEOS)
}
+// crbug.com/105728: Fails because the CRX is invalid.
IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest,
- GalleryInstallGetsExperimental) {
- InstallExtension(test_data_dir_.AppendASCII("experimental.crx"), 0);
- InstallExtensionFromWebstore(
- test_data_dir_.AppendASCII("experimental.crx"), 1);
+ FAILS_GalleryInstallGetsExperimental) {
+ ASSERT_FALSE(InstallExtension(
+ test_data_dir_.AppendASCII("experimental.crx"), 0));
+ ASSERT_TRUE(InstallExtensionFromWebstore(
+ test_data_dir_.AppendASCII("experimental.crx"), 1));
}
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698