Reapply "Fix the ScopeIterator reimplementation".

Reapply "Fix the ScopeIterator reimplementation".

This reapplies a fixed version of r10076 that also works on arm. Patch set one is r10076 reapplied and patch set 2 contains the new fix.

Committed: http://code.google.com/p/v8/source/detail?r=10080

[Steven, 2011-11-28 18:00:13]

PTAL.

[Lasse Reichstein, 2011-11-29 08:07:27]

LGTM.
Don't bother removing PartialPreParse now. It should go away eventually, but
there is no rush.

http://codereview.chromium.org/8725001/diff/2001/src/ast.h
File src/ast.h (right):

http://codereview.chromium.org/8725001/diff/2001/src/ast.h#newcode1179
src/ast.h:1179: friend class Rewriter;
Is it really necessary to make Rewriter a friend? Just make the generic
constructor public instead. If someone outside needs to use the code, it
probably shouldn't be private.

http://codereview.chromium.org/8725001/diff/2001/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/8725001/diff/2001/src/parser.cc#newcode5544
src/parser.cc:5544: ScriptDataImpl* ParserApi::PartialPreParse(Handle<String>
source,
For what it's worth, there is no longer any need for a PartialPreParse function,
or partial preparsing functionality.  
PartialPreParse was a smaller version of the offline preparser, used only for
preparsing just before parsing. That shouldn't be done any more. The
PartialParserRecorder can be deleted too, since the inline lazy function body
"preparsing" doesn't use it.

[Steven, 2011-11-29 08:45:30]

http://codereview.chromium.org/8725001/diff/2001/src/ast.h
File src/ast.h (right):

http://codereview.chromium.org/8725001/diff/2001/src/ast.h#newcode1179
src/ast.h:1179: friend class Rewriter;
Done. Also unfriended Scope :P
On 2011/11/29 08:07:27, Lasse Reichstein wrote:
> Is it really necessary to make Rewriter a friend? Just make the generic
> constructor public instead. If someone outside needs to use the code, it
> probably shouldn't be private.