test/cctest/test-parsing.cc - Issue 8725001: Reapply "Fix the ScopeIterator reimplementation".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-parsing.cc

Issue 8725001: Reapply "Fix the ScopeIterator reimplementation". (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use BreakLocationIterator to discover break at return. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-parsing.cc

diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc

index 15efd086effe81f646e0c3e07f2ca3a9bb32ea3f..bd1e24e11529f977b65cfe069eafa5ad34b62d33 100755

--- a/test/cctest/test-parsing.cc

+++ b/test/cctest/test-parsing.cc

@@ -349,10 +349,10 @@ TEST(Regress928) {

"try { } catch (e) { var foo = function () { /* first */ } }"

"var bar = function () { /* second */ }";

- i::Utf8ToUC16CharacterStream stream(reinterpret_cast<const i::byte*>(program),

- static_cast<unsigned>(strlen(program)));

- i::ScriptDataImpl* data =

- i::ParserApi::PartialPreParse(&stream, NULL, false);

+ v8::HandleScope handles;

+ i::Handle<i::String> source(

+ FACTORY->NewStringFromAscii(i::CStrVector(program)));

+ i::ScriptDataImpl* data = i::ParserApi::PartialPreParse(source, NULL, false);

CHECK(!data->HasError());

data->Initialize();