Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870005: Move gl_Bench into a dep so that it can be re-used among tests (Closed)

Created:
10 years, 9 months ago by piman
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, papakipos
Visibility:
Public.

Description

Move gl_Bench into a dep so that it can be re-used among tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, --12 lines) Patch
A client/deps/glbench/README View 1 chunk +7 lines, -0 lines 0 comments Download
A client/deps/glbench/common.py View 1 chunk +12 lines, -0 lines 0 comments Download
A client/deps/glbench/control View 1 chunk +5 lines, -0 lines 0 comments Download
A client/deps/glbench/glbench.py View 1 chunk +21 lines, -0 lines 0 comments Download
A + client/deps/glbench/src.orig/Makefile View 1 chunk +1 line, -1 line 0 comments Download
A + client/deps/glbench/src.orig/bench.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/egl_stuff.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/glx_stuff.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/image.yuv View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/main.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/main.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/shaders.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/shaders.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/utils.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/xlib_window.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/xlib_window.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/yuv2rgb.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/yuv2rgb_1.glslf View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/yuv2rgb_1.glslv View 0 chunks +-1 lines, --1 lines 0 comments Download
client/deps/glbench/src.orig/yuv2rgb_2.glslf View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/deps/glbench/src.orig/yuv2rgb_2.glslv View 0 chunks +-1 lines, --1 lines 0 comments Download
M client/site_tests/gl_Bench/gl_Bench.py View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
piman
The sources themselves didn't get modified aside from a minor name change in the Makefile.
10 years, 9 months ago (2010-03-12 01:18:29 UTC) #1
Alexey Marinichev
cc files LGTM, Darin would be a better person to comment on autotest-related stuff.
10 years, 9 months ago (2010-03-12 01:23:06 UTC) #2
petkov
10 years, 9 months ago (2010-03-12 01:25:37 UTC) #3 
LGTM too

Powered by Google App Engine
This is Rietveld 408576698