Add UMA for default content settings values, and default content settings changed actions.

Add UMA for default content settings values, and default content settings changed actions.

BUG=TODO
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112182

[markusheintz_, 2011-11-28 12:50:28]

Please review my CL.

[battre, 2011-11-28 14:17:10]

LGTM if you check that the enum value range is correct (as discussed in person).

http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:724: break;
I noticed that several content setting types don't occur here
(auto_select_certificate, fullscreen, mouselock). Is this intended?

[Patrick Dubroy, 2011-11-28 14:42:30]

LGTM assuming you fix the typo. :-)

http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:695:
UserMetricsAction("DefaultCookieSettingChanged"));
Maybe name these something like "DefaultSettings_CookieSettingChanged"? Doesn't
sound as good but it would be better for grouping purposes.

http://codereview.chromium.org/8698006/diff/6001/chrome/tools/chromeactions.txt
File chrome/tools/chromeactions.txt (right):

http://codereview.chromium.org/8698006/diff/6001/chrome/tools/chromeactions.t...
chrome/tools/chromeactions.txt:216:
0x3fe72e337aa2e482	DefaulJavaScriptSettingChanged
Typo ("Defaul").

[markusheintz_, 2011-11-28 15:18:41]

@Jochen: I'd like to replace "CookieBlockingEnabledPerDefault" and
"CookieBlockingDisabledPerDefault"

With an histogram, pls take a look at this. Thanks

http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:695:
UserMetricsAction("DefaultCookieSettingChanged"));
On 2011/11/28 14:42:30, dubroy wrote:
> Maybe name these something like "DefaultSettings_CookieSettingChanged"?
Doesn't
> sound as good but it would be better for grouping purposes.

I chose the
ContentSetting_Default<ContentSettingsType>SettingChanged scheme.

This way we can group all content settings UMA together.

http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:724: break;
On 2011/11/28 14:17:10, battre wrote:
> I noticed that several content setting types don't occur here
> (auto_select_certificate, fullscreen, mouselock). Is this intended?

Auto_select_certificate and fullscreen have no default setting that can be set
by a user.

mouslock was a good catch. Thanks!

http://codereview.chromium.org/8698006/diff/6001/chrome/tools/chromeactions.txt
File chrome/tools/chromeactions.txt (right):

http://codereview.chromium.org/8698006/diff/6001/chrome/tools/chromeactions.t...
chrome/tools/chromeactions.txt:216:
0x3fe72e337aa2e482	DefaulJavaScriptSettingChanged
On 2011/11/28 14:42:30, dubroy wrote:
> Typo ("Defaul").

Ahhh I already fixed this, forgot to run the script to update this file.

[jochen (gone - plz use gerrit), 2011-11-28 15:30:15]

On 2011/11/28 15:18:41, markusheintz_ wrote:
> @Jochen: I'd like to replace "CookieBlockingEnabledPerDefault" and
> "CookieBlockingDisabledPerDefault"
> 
> With an histogram, pls take a look at this. Thanks

that's fine by me

> 
>
http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
> File chrome/browser/ui/webui/options/content_settings_handler.cc (right):
> 
>
http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
> chrome/browser/ui/webui/options/content_settings_handler.cc:695:
> UserMetricsAction("DefaultCookieSettingChanged"));
> On 2011/11/28 14:42:30, dubroy wrote:
> > Maybe name these something like "DefaultSettings_CookieSettingChanged"?
> Doesn't
> > sound as good but it would be better for grouping purposes.
> 
> I chose the
> ContentSetting_Default<ContentSettingsType>SettingChanged scheme.
> 
> This way we can group all content settings UMA together.
> 
>
http://codereview.chromium.org/8698006/diff/6001/chrome/browser/ui/webui/opti...
> chrome/browser/ui/webui/options/content_settings_handler.cc:724: break;
> On 2011/11/28 14:17:10, battre wrote:
> > I noticed that several content setting types don't occur here
> > (auto_select_certificate, fullscreen, mouselock). Is this intended?
> 
> Auto_select_certificate and fullscreen have no default setting that can be set
> by a user.
> 
> mouslock was a good catch. Thanks!
> 
>
http://codereview.chromium.org/8698006/diff/6001/chrome/tools/chromeactions.txt
> File chrome/tools/chromeactions.txt (right):
> 
>
http://codereview.chromium.org/8698006/diff/6001/chrome/tools/chromeactions.t...
> chrome/tools/chromeactions.txt:216:
> 0x3fe72e337aa2e482	DefaulJavaScriptSettingChanged
> On 2011/11/28 14:42:30, dubroy wrote:
> > Typo ("Defaul").
> 
> Ahhh I already fixed this, forgot to run the script to update this file.

[commit-bot: I haz the power, 2011-11-29 08:24:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/8698006/5006

[commit-bot: I haz the power, 2011-11-29 10:44:21]

Try job failure for 8698006-5006 (retry) (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "media_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-30 08:17:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/8698006/5006

[commit-bot: I haz the power, 2011-11-30 08:35:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/8698006/5006

[commit-bot: I haz the power, 2011-11-30 09:55:06]

Change committed as 112182