Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/browser/content_settings/content_settings_default_provider.cc

Issue 8698006: Add UMA for default content settings values, and default content settings changed actions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unrelated changes. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/content_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/content_settings_default_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_default_provider.cc b/chrome/browser/content_settings/content_settings_default_provider.cc
index 15b31de6d5bba2983be216e8b462d2b9861a7ee8..a2a1c73f24789370cb5a2d902998e8787b0f9554 100644
--- a/chrome/browser/content_settings/content_settings_default_provider.cc
+++ b/chrome/browser/content_settings/content_settings_default_provider.cc
@@ -10,6 +10,7 @@
#include "base/auto_reset.h"
#include "base/basictypes.h"
#include "base/command_line.h"
+#include "base/metrics/histogram.h"
#include "chrome/browser/content_settings/content_settings_rule.h"
#include "chrome/browser/content_settings/content_settings_utils.h"
#include "chrome/browser/prefs/pref_service.h"
@@ -111,15 +112,51 @@ DefaultProvider::DefaultProvider(PrefService* prefs, bool incognito)
// Read global defaults.
ReadDefaultSettings(true);
- ContentSetting cookie_setting = ValueToContentSetting(
- default_settings_[CONTENT_SETTINGS_TYPE_COOKIES].get());
- if (cookie_setting == CONTENT_SETTING_BLOCK) {
- UserMetrics::RecordAction(
- UserMetricsAction("CookieBlockingEnabledPerDefault"));
- } else {
- UserMetrics::RecordAction(
- UserMetricsAction("CookieBlockingDisabledPerDefault"));
- }
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultCookiesSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_COOKIES].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultImagesSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_IMAGES].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultJavaScriptSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_JAVASCRIPT].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultPluginsSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_PLUGINS].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultPopupsSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_POPUPS].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultLocationSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_GEOLOCATION].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultNotificationsSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_NOTIFICATIONS].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultHandlersSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_INTENTS].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultMouseCursorSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_MOUSELOCK].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
pref_change_registrar_.Init(prefs_);
pref_change_registrar_.Add(prefs::kDefaultContentSettings, this);
« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/content_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698