Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 8698006: Add UMA for default content settings values, and default content settings changed actions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unrelated changes. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 4fe3e9b80bfef28ac4593f93b549ec5adef8f82a..3260f5f18a44189662a60b525b81dd266e0d682f 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -29,6 +29,7 @@
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "content/browser/tab_contents/tab_contents.h"
+#include "content/browser/user_metrics.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_source.h"
#include "content/public/browser/notification_types.h"
@@ -688,6 +689,46 @@ void ContentSettingsHandler::SetContentFilter(const ListValue* args) {
GetContentSettingsMap()->
SetDefaultContentSetting(content_type, default_setting);
}
+ switch (content_type) {
+ case CONTENT_SETTINGS_TYPE_COOKIES:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSetting_DefaultCookieSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_IMAGES:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSetting_DefaultImagesSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_JAVASCRIPT:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSetting_DefaultJavaScriptSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_PLUGINS:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSetting_DefaultPluginsSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_POPUPS:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSettings_DefaultPopupsSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSettings_DefaultNotificationsSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSetting_DefaultGeolocationSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_INTENTS:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSetting_DefaultHandlersSettingChanged"));
+ break;
+ case CONTENT_SETTINGS_TYPE_MOUSELOCK:
+ UserMetrics::RecordAction(UserMetricsAction(
+ "ContentSettings_DefaultMouseLockSettingChanged"));
+ break;
+ default:
+ break;
+ }
}
void ContentSettingsHandler::RemoveException(const ListValue* args) {
« no previous file with comments | « chrome/browser/content_settings/content_settings_default_provider.cc ('k') | chrome/tools/chromeactions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698