Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8695005: Move accelerator related files to ui/base/accelerators (Closed)

Created:
9 years, 1 month ago by tfarina
Modified:
9 years ago
Reviewers:
mazda
CC:
chromium-reviews, alicet1, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, msw+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., dhollowa, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Move accelerator related files to ui/base/accelerators BUG=104599 R=mazda@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111597

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -663 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/accelerators_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/accelerators_gtk_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bubble/bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/menu_model_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura_shell/shell_accelerator_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura_shell/shell_accelerator_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura_shell/shell_accelerator_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ui/base/accelerator_manager.h View 1 chunk +0 lines, -65 lines 0 comments Download
D ui/base/accelerator_manager.cc View 1 chunk +0 lines, -77 lines 0 comments Download
A + ui/base/accelerators/accelerator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/base/accelerators/accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/base/accelerators/accelerator_cocoa.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/base/accelerators/accelerator_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ui/base/accelerators/accelerator_gtk.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/base/accelerators/accelerator_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/base/accelerators/accelerator_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
ui/base/models/accelerator.h View 1 chunk +0 lines, -129 lines 0 comments Download
D ui/base/models/accelerator.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D ui/base/models/accelerator_cocoa.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/base/models/accelerator_cocoa.mm View 1 chunk +0 lines, -41 lines 0 comments Download
D ui/base/models/accelerator_gtk.h View 1 chunk +0 lines, -59 lines 0 comments Download
M ui/base/ui_base_exports.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/tree/tree_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/accelerator_handler_gtk_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/accessible_pane_view.h View 1 chunk +1 line, -1 line 0 comments Download
M views/accessible_pane_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/native_menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 1 month ago (2011-11-24 19:24:14 UTC) #1
mazda
9 years ago (2011-11-25 13:54:06 UTC) #2 
lgtm

Thank you for working on this.

Powered by Google App Engine
This is Rietveld 408576698