Improve GPU tests to fail when GPU drawing fails

Improve GPU tests to fail when GPU drawing fails.

Changed the accelerated html pages to use raf to draw multiple frames. Changed the webgl and canvas2d pages to draw onscreen rather than offscreen to make sure the compositor draws the page.

BUG=105785, 104142
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112763

[jbates, 2011-11-30 02:24:35]

ptal

http://codereview.chromium.org/8692013/diff/2001/chrome/test/gpu/gpu_feature_...
File chrome/test/gpu/gpu_feature_browsertest.cc (left):

http://codereview.chromium.org/8692013/diff/2001/chrome/test/gpu/gpu_feature_...
chrome/test/gpu/gpu_feature_browsertest.cc:108: #endif
Let's see if this works now...

[Zhenyao Mo, 2011-11-30 18:58:47]

LGTM with two minor issues.  Land if you can turn try bots green.

http://codereview.chromium.org/8692013/diff/2001/chrome/test/data/gpu/feature...
File chrome/test/data/gpu/feature_webgl.html (right):

http://codereview.chromium.org/8692013/diff/2001/chrome/test/data/gpu/feature...
chrome/test/data/gpu/feature_webgl.html:34: gl.viewport(0, 0, gl.viewportWidth,
gl.viewportHeight);
I don't think viewportWidth/Height are supported.

http://codereview.chromium.org/8692013/diff/2001/chrome/test/gpu/gpu_feature_...
File chrome/test/gpu/gpu_feature_browsertest.cc (right):

http://codereview.chromium.org/8692013/diff/2001/chrome/test/gpu/gpu_feature_...
chrome/test/gpu/gpu_feature_browsertest.cc:77: }
This should match the previous line EXPECT_EQ style (or the previous one
matching this).

[jbates, 2011-11-30 20:21:52]

Beginning the trybot investigation...

http://codereview.chromium.org/8692013/diff/2001/chrome/test/data/gpu/feature...
File chrome/test/data/gpu/feature_webgl.html (right):

http://codereview.chromium.org/8692013/diff/2001/chrome/test/data/gpu/feature...
chrome/test/data/gpu/feature_webgl.html:34: gl.viewport(0, 0, gl.viewportWidth,
gl.viewportHeight);
On 2011/11/30 18:58:47, Zhenyao Mo wrote:
> I don't think viewportWidth/Height are supported.

Done.

http://codereview.chromium.org/8692013/diff/2001/chrome/test/gpu/gpu_feature_...
File chrome/test/gpu/gpu_feature_browsertest.cc (right):

http://codereview.chromium.org/8692013/diff/2001/chrome/test/gpu/gpu_feature_...
chrome/test/gpu/gpu_feature_browsertest.cc:77: }
On 2011/11/30 18:58:47, Zhenyao Mo wrote:
> This should match the previous line EXPECT_EQ style (or the previous one
> matching this).

Done.

[jbates, 2011-12-01 20:45:13]

PTAL
kbr: content/*/gpu/ owners review
thakis: base/ owners review

[Nico, 2011-12-01 20:50:31]

base lgtm

[Ken Russell (switch to Gerrit), 2011-12-01 22:21:27]

content/*/gpu LGTM

Thanks for beefing up these tests.

[commit-bot: I haz the power, 2011-12-01 23:11:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbates@chromium.org/8692013/14001

[commit-bot: I haz the power, 2011-12-01 23:30:03]

Try job failure for 8692013-14001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-01 23:36:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbates@chromium.org/8692013/14001

[commit-bot: I haz the power, 2011-12-02 01:29:07]

Try job failure for 8692013-14001 (retry) on win_rel for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-02 18:03:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbates@chromium.org/8692013/14001

[commit-bot: I haz the power, 2011-12-02 19:45:08]

Change committed as 112763