Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: content/common/gpu/gpu_command_buffer_stub.cc

Issue 8692013: Improve GPU tests to fail when GPU drawing fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-added DLOG Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | content/gpu/gpu_child_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_command_buffer_stub.cc
diff --git a/content/common/gpu/gpu_command_buffer_stub.cc b/content/common/gpu/gpu_command_buffer_stub.cc
index 195cf6ec63b11a53f38b7e0e031b85cc992db213..af478e08dc35a311685a08db18deffc925283ede 100644
--- a/content/common/gpu/gpu_command_buffer_stub.cc
+++ b/content/common/gpu/gpu_command_buffer_stub.cc
@@ -164,6 +164,8 @@ void GpuCommandBufferStub::OnInitialize(
IPC::Message* reply_message) {
DCHECK(!command_buffer_.get());
+ UNSHIPPED_TRACE_EVENT_INSTANT0("test_gpu", "TryCreateGLContext");
+
command_buffer_.reset(new gpu::CommandBufferService);
#if defined(OS_WIN)
@@ -179,6 +181,7 @@ void GpuCommandBufferStub::OnInitialize(
#endif
if (!command_buffer_->Initialize(&shared_memory, size)) {
+ DLOG(ERROR) << "CommandBufferService failed to initialize.\n";
OnInitializeFailed(reply_message);
return;
}
@@ -194,6 +197,7 @@ void GpuCommandBufferStub::OnInitialize(
if (handle_) {
#if defined(OS_MACOSX) || defined(UI_COMPOSITOR_IMAGE_TRANSPORT)
if (software_) {
+ DLOG(ERROR) << "No software support.\n";
OnInitializeFailed(reply_message);
return;
}
@@ -278,6 +282,9 @@ void GpuCommandBufferStub::OnInitialize(
GpuCommandBufferMsg_Initialize::WriteReplyParams(reply_message, true);
Send(reply_message);
+
+ UNSHIPPED_TRACE_EVENT_INSTANT1("test_gpu", "CreateGLContextSuccess",
+ "offscreen", surface_->IsOffscreen());
}
void GpuCommandBufferStub::OnSetParent(int32 parent_route_id,
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | content/gpu/gpu_child_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698