Create a field test for sync sign in promo strings.

chrome/browser/ui/webui/sync_setup_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_setup_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
@@ skipping 366 matching lines @@
     { "sectionExplicitMessagePrefix", IDS_SYNC_PASSPHRASE_MSG_EXPLICIT_PREFIX },
     { "sectionExplicitMessagePostfix",
         IDS_SYNC_PASSPHRASE_MSG_EXPLICIT_POSTFIX },
     { "encryptedDataTypesTitle", IDS_SYNC_ENCRYPTION_DATA_TYPES_TITLE },
     { "encryptSensitiveOption", IDS_SYNC_ENCRYPT_SENSITIVE_DATA },
     { "encryptAllOption", IDS_SYNC_ENCRYPT_ALL_DATA },
     { "encryptAllOption", IDS_SYNC_ENCRYPT_ALL_DATA },
     { "aspWarningText", IDS_SYNC_ASP_PASSWORD_WARNING_TEXT },
     { "promoPageTitle", IDS_SYNC_PROMO_TAB_TITLE},
     { "promoMessageBody", IDS_SYNC_PROMO_MESSAGE_BODY},
+    { "promoMessageBodyA", IDS_SYNC_PROMO_MESSAGE_BODY_A},

[sail, 2011/11/28 16:34:25]

instead of having multiple strings here and then doing a javascript call to
change the string it would be simpler to do something like this:
       SyncPromoUIHTMLSource::SyncPromoUIHTMLSource(WebUI* web_ui) {
         SyncSetupHandler::GetStaticLocalizedValues(&localized_strings)
         SyncPromoHandler::GetStaticLocalizedValues(&localized_strings, web_ui)
       }

       SyncSetupHandler::GetStaticLocalizedValues(DictionaryValue*
localized_strings, WebUI* web_ui) {
                if (IsInExperiment())
                                ...
        }
       }

If you could figure out a way to get rid of GetStaticLocalizedValues() and just
use GetLocalizedValues() then that would be even better!

[SteveT, 2011/11/28 20:07:32]

So I addressed this roughly in the way you suggested. It's not the tidiest
solution since we had to introduce a dependency on a WebUI object, and
NTPResourceCache is not capable of providing it (see my new TODO). Maybe
jhawkins has some suggestions on how to fix this.. plus the use of
GetStaticLocalizedValues.

+    { "promoMessageBodyB", IDS_SYNC_PROMO_MESSAGE_BODY_B},
+    { "promoMessageBodyC", IDS_SYNC_PROMO_MESSAGE_BODY_C},
+    { "promoMessageBodyD", IDS_SYNC_PROMO_MESSAGE_BODY_D},
     { "promoSkipButton", IDS_SYNC_PROMO_SKIP_BUTTON},
     { "promoAdvanced", IDS_SYNC_PROMO_ADVANCED},
     { "promoLearnMoreShow", IDS_SYNC_PROMO_LEARN_MORE_SHOW},
     { "promoLearnMoreHide", IDS_SYNC_PROMO_LEARN_MORE_HIDE},
     { "promoInformation", IDS_SYNC_PROMO_INFORMATION},
   };
 
   RegisterStrings(localized_strings, resources, arraysize(resources));
 }
 
@@ skipping 347 matching lines @@
 }
 
 void SyncSetupHandler::ShowLoginErrorMessage(const string16& error_message) {
   DictionaryValue args;
   Profile* profile = Profile::FromWebUI(web_ui_);
   ProfileSyncService* service = profile->GetProfileSyncService();
   SyncSetupFlow::GetArgsForGaiaLogin(service, &args);
   args.SetString("error_message", error_message);
   ShowGaiaLogin(args);
 }