Issue 8678019: Move sensors interface into content/public/browser (since it's only used by browser directory). M...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8678019: Move sensors interface into content/public/browser (since it's only used by browser directory). M... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
cwolfe

CC:
chromium-reviews, nkostylev+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move sensors interface into content/public/browser (since it's only used by browser directory). Move everything into the content namespace and make the enums conform to the Content API convention. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111417

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : fix aura typo #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -125 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/dbus/sensors_client.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/aura/screen_orientation_listener.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/aura/screen_orientation_listener.cc	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/sensors/sensors_provider.h	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	content/browser/sensors/sensors_provider_impl.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/sensors/sensors_provider_impl.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
D	content/common/sensors.h	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	content/common/sensors_listener.h	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A +	content/public/browser/sensors.h	View		2 chunks	+15 lines, -19 lines	0 comments	Download
A +	content/public/browser/sensors_listener.h	View	1	2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cwolfe

LGTM, thanks. Is sensors_provider.h [eventually] supposed to move into public as well?

9 years ago (2011-11-23 19:20:05 UTC) #2

jam

9 years ago (2011-11-23 19:21:56 UTC) #3

On Wed, Nov 23, 2011 at 11:20 AM, <cwolfe@chromium.org> wrote:

> LGTM, thanks.
>
> Is sensors_provider.h [eventually] supposed to move into public as well?
>

Exactly. I'm starting with removing content\common dependencies from
chrome\browser. Once that's done I'll move on to removing content\browser
dependencies.

>
>
http://codereview.chromium.**org/8678019/<http://codereview.chromium.org/8678...
>

Expand Messages | Collapse Messages