- Refactor the isolate callback mechanism to also include creation of the

vm/isolate_linux.cc

Index: vm/isolate_linux.cc
===================================================================
--- vm/isolate_linux.cc	(revision 1771)
+++ vm/isolate_linux.cc	(working copy)
@@ -30,8 +30,8 @@
 
 
 // Empty isolate init callback which is registered before VM isolate creation.
-static void* VMIsolateInitCallback(void* data) {
-  return reinterpret_cast<void*>(1);
+static bool VMIsolateInitCallback(Dart_IsolateError error) {

[turnidge, 2011/11/23 18:05:12]

Maybe rename to "VMIsolateCreateCallback".

[siva, 2011/11/23 22:37:27]

Done.

+  return true;
 }
 
 
@@ -41,7 +41,7 @@
   // Make sure creating a key was successful.
   VALIDATE_PTHREAD_RESULT(result);
   ASSERT(isolate_key != PTHREAD_KEY_UNSET);
-  init_callback_ = VMIsolateInitCallback;
+  create_init_callback_ = VMIsolateInitCallback;
 }
 
 }  // namespace dart