Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: vm/isolate_macos.cc

Issue 8673002: - Refactor the isolate callback mechanism to also include creation of the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/isolate_macos.cc
===================================================================
--- vm/isolate_macos.cc (revision 1771)
+++ vm/isolate_macos.cc (working copy)
@@ -30,8 +30,8 @@
// Empty isolate init callback which is registered before VM isolate creation.
-static void* VMIsolateInitCallback(void* data) {
- return reinterpret_cast<void*>(1);
+static bool VMIsolateInitCallback(Dart_IsolateError error) {
turnidge 2011/11/23 18:05:12 Init => Create
siva 2011/11/23 22:37:27 Done.
+ return true;
}
@@ -41,7 +41,7 @@
// Make sure creating a key was successful.
VALIDATE_PTHREAD_RESULT(result);
ASSERT(isolate_key != PTHREAD_KEY_UNSET);
- init_callback_ = VMIsolateInitCallback;
+ create_init_callback_ = VMIsolateInitCallback;
}
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698