- Refactor the isolate callback mechanism to also include creation of the

vm/isolate_linux.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <errno.h>
 #include <pthread.h>
 
 #include "vm/assert.h"
 #include "vm/isolate.h"
 
@@ skipping 12 matching lines @@
 
 
 void Isolate::SetCurrent(Isolate* current) {
   ASSERT(isolate_key != PTHREAD_KEY_UNSET);
   int result = pthread_setspecific(isolate_key, current);
   VALIDATE_PTHREAD_RESULT(result);
 }
 
 
 // Empty isolate init callback which is registered before VM isolate creation.
-static void* VMIsolateInitCallback(void* data) {
-  return reinterpret_cast<void*>(1);
+static bool VMIsolateInitCallback(Dart_IsolateError error) {

[turnidge, 2011/11/23 18:05:12]

Maybe rename to "VMIsolateCreateCallback".

[siva, 2011/11/23 22:37:27]

Done.

+  return true;
 }
 
 
 void Isolate::InitOnce() {
   ASSERT(isolate_key == PTHREAD_KEY_UNSET);
   int result = pthread_key_create(&isolate_key, NULL);
   // Make sure creating a key was successful.
   VALIDATE_PTHREAD_RESULT(result);
   ASSERT(isolate_key != PTHREAD_KEY_UNSET);
-  init_callback_ = VMIsolateInitCallback;
+  create_init_callback_ = VMIsolateInitCallback;
 }
 
 }  // namespace dart