Index: chrome/browser/ui/views/extensions/extension_popup.cc |
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc |
index 8b111feb7daeb023408df08fc4ece75e63178ed3..47f04bf77e1a09a2d9505faadf974c7683cfb5ef 100644 |
--- a/chrome/browser/ui/views/extensions/extension_popup.cc |
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc |
@@ -39,6 +39,10 @@ const int ExtensionPopup::kMinHeight = 25; |
const int ExtensionPopup::kMaxWidth = 800; |
const int ExtensionPopup::kMaxHeight = 600; |
+// @@@MP ownership: EH owns TC. We have weakref to TC. when we tell TC to close, |
+// EH deletes itself? Or maybe we hold a ref to a TCHolderInterface that has |
+// a GetTC and Close method? |
Matt Perry
2011/11/23 02:51:20
ignore this file
|
+ |
ExtensionPopup::ExtensionPopup( |
Browser* browser, |
ExtensionHost* host, |
@@ -61,11 +65,13 @@ ExtensionPopup::ExtensionPopup( |
host->view()->SetContainer(this); |
// We wait to show the popup until the contained host finishes loading. |
+ // @@@MP listen for TCO::DidStopLoading |
registrar_.Add(this, |
chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING, |
content::Source<Profile>(host->profile())); |
// Listen for the containing view calling window.close(); |
+ // @@@MP listen for TCO::TabContentsDestroyed? see ownership |
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE, |
content::Source<Profile>(host->profile())); |
} |