Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3782)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 8669014: Fix a bug where redirect chain gets lost on process swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.cc
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc
index 8b111feb7daeb023408df08fc4ece75e63178ed3..47f04bf77e1a09a2d9505faadf974c7683cfb5ef 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.cc
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc
@@ -39,6 +39,10 @@ const int ExtensionPopup::kMinHeight = 25;
const int ExtensionPopup::kMaxWidth = 800;
const int ExtensionPopup::kMaxHeight = 600;
+// @@@MP ownership: EH owns TC. We have weakref to TC. when we tell TC to close,
+// EH deletes itself? Or maybe we hold a ref to a TCHolderInterface that has
+// a GetTC and Close method?
Matt Perry 2011/11/23 02:51:20 ignore this file
+
ExtensionPopup::ExtensionPopup(
Browser* browser,
ExtensionHost* host,
@@ -61,11 +65,13 @@ ExtensionPopup::ExtensionPopup(
host->view()->SetContainer(this);
// We wait to show the popup until the contained host finishes loading.
+ // @@@MP listen for TCO::DidStopLoading
registrar_.Add(this,
chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
content::Source<Profile>(host->profile()));
// Listen for the containing view calling window.close();
+ // @@@MP listen for TCO::TabContentsDestroyed? see ownership
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,
content::Source<Profile>(host->profile()));
}

Powered by Google App Engine
This is Rietveld 408576698