Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: chrome/browser/renderer_host/chrome_url_request_user_data.cc

Issue 8669014: Fix a bug where redirect chain gets lost on process swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_url_request_user_data.cc
diff --git a/chrome/browser/renderer_host/chrome_url_request_user_data.cc b/chrome/browser/renderer_host/chrome_url_request_user_data.cc
index aeabcd1285e7b4235d8acc7c3e6d01890a8bbd17..38545aa4fbc0e80793c899a43c12bfb3f99ed3d6 100644
--- a/chrome/browser/renderer_host/chrome_url_request_user_data.cc
+++ b/chrome/browser/renderer_host/chrome_url_request_user_data.cc
@@ -25,7 +25,10 @@ ChromeURLRequestUserData* ChromeURLRequestUserData::Get(
ChromeURLRequestUserData* ChromeURLRequestUserData::Create(
net::URLRequest* request) {
DCHECK(request);
- DCHECK(!Get(request));
+ // TODO(mpcomplete): since we're reusing an old URLRequest, this DCHECK
+ // gets hit. We should add a way to clear the UserData for retargeted
+ // requests.
+ //DCHECK(!Get(request));
ChromeURLRequestUserData* user_data = new ChromeURLRequestUserData();
request->SetUserData(kKeyName, user_data);
return user_data;

Powered by Google App Engine
This is Rietveld 408576698