Fix a bug where redirect chain gets lost on process swap.

chrome/browser/ui/views/extensions/extension_popup.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_popup.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "chrome/browser/debugger/devtools_window.h"
@@ skipping 21 matching lines @@
 using views::Widget;
 
 // The minimum/maximum dimensions of the popup.
 // The minimum is just a little larger than the size of the button itself.
 // The maximum is an arbitrary number that should be smaller than most screens.
 const int ExtensionPopup::kMinWidth = 25;
 const int ExtensionPopup::kMinHeight = 25;
 const int ExtensionPopup::kMaxWidth = 800;
 const int ExtensionPopup::kMaxHeight = 600;
 
+// @@@MP ownership: EH owns TC. We have weakref to TC. when we tell TC to close,
+// EH deletes itself? Or maybe we hold a ref to a TCHolderInterface that has
+// a GetTC and Close method?

[Matt Perry, 2011/11/23 02:51:20]

ignore this file

+
 ExtensionPopup::ExtensionPopup(
     Browser* browser,
     ExtensionHost* host,
     const gfx::Rect& relative_to,
     views::BubbleBorder::ArrowLocation arrow_location,
     bool inspect_with_devtools,
     Observer* observer)
     : BrowserBubble(browser,
                     host->view(),
                     relative_to,
                     arrow_location),
       relative_to_(relative_to),
       extension_host_(host),
       inspect_with_devtools_(inspect_with_devtools),
       close_on_lost_focus_(true),
       closing_(false),
       observer_(observer) {
   AddRef();  // Balanced in Close();
   set_delegate(this);
   host->view()->SetContainer(this);
 
   // We wait to show the popup until the contained host finishes loading.
+  // @@@MP listen for TCO::DidStopLoading
   registrar_.Add(this,
                  chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
                  content::Source<Profile>(host->profile()));
 
   // Listen for the containing view calling window.close();
+  // @@@MP listen for TCO::TabContentsDestroyed? see ownership
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,
                  content::Source<Profile>(host->profile()));
 }
 
 ExtensionPopup::~ExtensionPopup() {
   // Clear the delegate, because we might trigger UI events during destruction,
   // and we don't want to be called into anymore.
   set_delegate(NULL);
 }
 
@@ skipping 130 matching lines @@
   if (closing_)
     return;
   closing_ = true;
   DetachFromBrowser();
 
   if (observer_)
     observer_->ExtensionPopupIsClosing(this);
 
   Release();  // Balanced in ctor.
 }