Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3183)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_controller.mm

Issue 8624008: Make malicious content download warning include the download filename (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Address Asanka's comment. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/downloads.js ('k') | chrome/browser/ui/gtk/download/download_item_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/download/download_item_controller.mm
diff --git a/chrome/browser/ui/cocoa/download/download_item_controller.mm b/chrome/browser/ui/cocoa/download/download_item_controller.mm
index 9b11222ff124678e78764e4b01322da6805beb5f..d53d9538dbd9ba28188b50b2f473097d9f10b995 100644
--- a/chrome/browser/ui/cocoa/download/download_item_controller.mm
+++ b/chrome/browser/ui/cocoa/download/download_item_controller.mm
@@ -175,10 +175,11 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
// different cases.
if (downloadModel->download()->GetDangerType() ==
DownloadStateInfo::DANGEROUS_URL) {
+ // TODO(noelutz): add support for malicious content.
// Safebrowsing shows the download URL leads to malicious file.
alertIcon = rb.GetNativeImageNamed(IDR_SAFEBROWSING_WARNING);
dangerousWarning = l10n_util::GetNSStringWithFixup(
- IDS_PROMPT_UNSAFE_DOWNLOAD_URL);
+ IDS_PROMPT_MALICIOUS_DOWNLOAD_URL);
confirmButtonTitle = l10n_util::GetNSStringWithFixup(
IDS_CONFIRM_DOWNLOAD);
} else {
« no previous file with comments | « chrome/browser/resources/downloads.js ('k') | chrome/browser/ui/gtk/download/download_item_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698