move chromeos bubble setup code to window.cc

ui/views/bubble/bubble_delegate.h

Index: ui/views/bubble/bubble_delegate.h
diff --git a/ui/views/bubble/bubble_delegate.h b/ui/views/bubble/bubble_delegate.h
index b31c77d1ef6184d78ff4a08e764d62032ca13f4c..3b66cd83aad3fc15572726376e7aff223d4d20c2 100644
--- a/ui/views/bubble/bubble_delegate.h
+++ b/ui/views/bubble/bubble_delegate.h
@@ -67,6 +67,16 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
     use_focusless_ = use_focusless;
   }
 
+#if defined(OS_CHROMEOS)
+  bool show_while_screen_is_locked() const {
+    return show_while_screen_is_locked_;
+  }
+
+  void set_show_while_screen_is_locked(bool show) {
+    show_while_screen_is_locked_ = show;
+  }
+#endif
+
   // Get the arrow's anchor point in screen space.
   virtual gfx::Point GetAnchorPoint();
 
@@ -146,6 +156,9 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
   // These bubbles are not interactive and should not gain focus.
   bool use_focusless_;
 
+  // Whether to show this bubble when screen is locked on ChromeOS.

[Daniel Erat, 2011/11/21 23:10:50]

still seems weird to me to define this on platforms where it's not used, but i
guess that we already do the same thing for use_focusless_?  i suppose that the
ifdef around getter and setter should be removed for consistency (or
use_focusless_ should be ifdef-ed as well -- you could move both of these above
border_widget_ if the only objection is that it's difficult to put the ifdef in
the initialization list).

[alicet1, 2011/11/22 00:23:53]

removed.

+  bool show_while_screen_is_locked_;

[Ben Goodger (Google), 2011/11/21 23:12:38]

indeed... I think this should be hoisted to the chokepoint I described in
private email. views shouldn't know about "lock screens"

[alicet1, 2011/11/22 00:23:53]

removed.

+
   DISALLOW_COPY_AND_ASSIGN(BubbleDelegateView);
 };