move chromeos bubble setup code to window.cc

ui/views/bubble/bubble_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 #pragma once
 
 #include "base/gtest_prod_util.h"
 #include "ui/base/animation/animation_delegate.h"
@@ skipping 49 matching lines @@
   }
 
   View* anchor_view() const { return anchor_view_; }
   void set_anchor_view(View* anchor_view) { anchor_view_ = anchor_view; }
 
   bool use_focusless() const { return use_focusless_; }
   void set_use_focusless(bool use_focusless) {
     use_focusless_ = use_focusless;
   }
 
+#if defined(OS_CHROMEOS)
+  bool show_while_screen_is_locked() const {
+    return show_while_screen_is_locked_;
+  }
+
+  void set_show_while_screen_is_locked(bool show) {
+    show_while_screen_is_locked_ = show;
+  }
+#endif
+
   // Get the arrow's anchor point in screen space.
   virtual gfx::Point GetAnchorPoint();
 
   // Get the arrow's location on the bubble.
   virtual BubbleBorder::ArrowLocation GetArrowLocation() const;
 
   // Get the color used for the background and border.
   virtual SkColor GetColor() const;
 
   // Show the bubble's widget (and |border_widget_| on Windows).
@@ skipping 59 matching lines @@
   // Original opacity of the bubble.
   int original_opacity_;
 
   // The widget hosting the border for this bubble (non-Aura Windows only).
   Widget* border_widget_;
 
   // Create a popup window for focusless bubbles on Linux/ChromeOS.
   // These bubbles are not interactive and should not gain focus.
   bool use_focusless_;
 
+  // Whether to show this bubble when screen is locked on ChromeOS.

[Daniel Erat, 2011/11/21 23:10:50]

still seems weird to me to define this on platforms where it's not used, but i
guess that we already do the same thing for use_focusless_?  i suppose that the
ifdef around getter and setter should be removed for consistency (or
use_focusless_ should be ifdef-ed as well -- you could move both of these above
border_widget_ if the only objection is that it's difficult to put the ifdef in
the initialization list).

[alicet1, 2011/11/22 00:23:53]

removed.

+  bool show_while_screen_is_locked_;

[Ben Goodger (Google), 2011/11/21 23:12:38]

indeed... I think this should be hoisted to the chokepoint I described in
private email. views shouldn't know about "lock screens"

[alicet1, 2011/11/22 00:23:53]

removed.

+
   DISALLOW_COPY_AND_ASSIGN(BubbleDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_